[PATCH v2 00/14] hw/pci-host/raven clean ups

BALATON Zoltan posted 14 patches 3 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1751493467.git.balaton@eik.bme.hu
Maintainers: "Hervé Poussineau" <hpoussin@reactos.org>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
There is a newer version of this series
hw/pci-host/raven.c       | 328 ++++++++++++--------------------------
hw/ppc/prep.c             |  19 ++-
hw/ppc/prep_systemio.c    |  14 +-
include/hw/pci/pci_host.h |   1 -
4 files changed, 127 insertions(+), 235 deletions(-)
[PATCH v2 00/14] hw/pci-host/raven clean ups
Posted by BALATON Zoltan 3 months, 3 weeks ago
Hello,

This series cleans up and simplifies the raven model which does some
strange stuff that no other pci-host is doing and does it in a
convoluted way and also has some legacy bits that can be removed.
Apart from making the model much more readable this also fixes the
non-contiguous IO control bit which was there but did not work as it
was not connected but apparently it's not really used by any guest so
that wasn't noticed.

Regards,
BALATON Zoltan

v2:
- rebase on master
- add R-b tags from Philippe

BALATON Zoltan (14):
  hw/pci-host/raven: Simplify PCI facing part
  hw/pci-host/raven: Simplify host bridge type declaration
  hw/pci-host/raven: Use DEFINE_TYPES macro
  hw/pci-host/raven: Simplify PCI bus creation
  hw/pci-host/raven: Simplify PCI interrupt routing
  hw/pci-host/raven: Simplify direct config access address decoding
  hw/pci-host/raven: Rename direct config access ops
  hw/pci-host/raven: Use correct parameter in direct access ops
  hw/pci-host/raven: Do not use parent object for mmcfg region
  hw/pci-host/raven: Fix PCI config direct access region
  hw/pci-host/raven: Simpify discontiguous IO access
  hw/pci-host/raven: Move bus master address space creation to one place
  hw/pci-host/raven: Do not map regions in init method
  hw/ppc/prep: Fix non-contiguous IO control bit

 hw/pci-host/raven.c       | 328 ++++++++++++--------------------------
 hw/ppc/prep.c             |  19 ++-
 hw/ppc/prep_systemio.c    |  14 +-
 include/hw/pci/pci_host.h |   1 -
 4 files changed, 127 insertions(+), 235 deletions(-)

-- 
2.41.3
Re: [PATCH v2 00/14] hw/pci-host/raven clean ups
Posted by BALATON Zoltan 1 month, 1 week ago
On Thu, 3 Jul 2025, BALATON Zoltan wrote:
> Hello,

Ping? Do we have hw/ppc maintainers who can look at this and merge it?

Regards,
BALATON Zoltan

> This series cleans up and simplifies the raven model which does some
> strange stuff that no other pci-host is doing and does it in a
> convoluted way and also has some legacy bits that can be removed.
> Apart from making the model much more readable this also fixes the
> non-contiguous IO control bit which was there but did not work as it
> was not connected but apparently it's not really used by any guest so
> that wasn't noticed.
>
> Regards,
> BALATON Zoltan
>
> v2:
> - rebase on master
> - add R-b tags from Philippe
>
> BALATON Zoltan (14):
>  hw/pci-host/raven: Simplify PCI facing part
>  hw/pci-host/raven: Simplify host bridge type declaration
>  hw/pci-host/raven: Use DEFINE_TYPES macro
>  hw/pci-host/raven: Simplify PCI bus creation
>  hw/pci-host/raven: Simplify PCI interrupt routing
>  hw/pci-host/raven: Simplify direct config access address decoding
>  hw/pci-host/raven: Rename direct config access ops
>  hw/pci-host/raven: Use correct parameter in direct access ops
>  hw/pci-host/raven: Do not use parent object for mmcfg region
>  hw/pci-host/raven: Fix PCI config direct access region
>  hw/pci-host/raven: Simpify discontiguous IO access
>  hw/pci-host/raven: Move bus master address space creation to one place
>  hw/pci-host/raven: Do not map regions in init method
>  hw/ppc/prep: Fix non-contiguous IO control bit
>
> hw/pci-host/raven.c       | 328 ++++++++++++--------------------------
> hw/ppc/prep.c             |  19 ++-
> hw/ppc/prep_systemio.c    |  14 +-
> include/hw/pci/pci_host.h |   1 -
> 4 files changed, 127 insertions(+), 235 deletions(-)
>
>
Re: [PATCH v2 00/14] hw/pci-host/raven clean ups
Posted by Mark Cave-Ayland 1 month, 1 week ago
On 17/09/2025 12:19, BALATON Zoltan wrote:

> On Thu, 3 Jul 2025, BALATON Zoltan wrote:
>> Hello,
> 
> Ping? Do we have hw/ppc maintainers who can look at this and merge it?

Apologies for the delay, things have been quite hectic here. I'll take a look now.

> Regards,
> BALATON Zoltan
> 
>> This series cleans up and simplifies the raven model which does some
>> strange stuff that no other pci-host is doing and does it in a
>> convoluted way and also has some legacy bits that can be removed.
>> Apart from making the model much more readable this also fixes the
>> non-contiguous IO control bit which was there but did not work as it
>> was not connected but apparently it's not really used by any guest so
>> that wasn't noticed.
>>
>> Regards,
>> BALATON Zoltan
>>
>> v2:
>> - rebase on master
>> - add R-b tags from Philippe
>>
>> BALATON Zoltan (14):
>>  hw/pci-host/raven: Simplify PCI facing part
>>  hw/pci-host/raven: Simplify host bridge type declaration
>>  hw/pci-host/raven: Use DEFINE_TYPES macro
>>  hw/pci-host/raven: Simplify PCI bus creation
>>  hw/pci-host/raven: Simplify PCI interrupt routing
>>  hw/pci-host/raven: Simplify direct config access address decoding
>>  hw/pci-host/raven: Rename direct config access ops
>>  hw/pci-host/raven: Use correct parameter in direct access ops
>>  hw/pci-host/raven: Do not use parent object for mmcfg region
>>  hw/pci-host/raven: Fix PCI config direct access region
>>  hw/pci-host/raven: Simpify discontiguous IO access
>>  hw/pci-host/raven: Move bus master address space creation to one place
>>  hw/pci-host/raven: Do not map regions in init method
>>  hw/ppc/prep: Fix non-contiguous IO control bit
>>
>> hw/pci-host/raven.c       | 328 ++++++++++++--------------------------
>> hw/ppc/prep.c             |  19 ++-
>> hw/ppc/prep_systemio.c    |  14 +-
>> include/hw/pci/pci_host.h |   1 -
>> 4 files changed, 127 insertions(+), 235 deletions(-)


ATB,

Mark.


Re: [PATCH v2 00/14] hw/pci-host/raven clean ups
Posted by BALATON Zoltan 1 month, 1 week ago
On Thu, 18 Sep 2025, Mark Cave-Ayland wrote:
> On 17/09/2025 12:19, BALATON Zoltan wrote:
>
>> On Thu, 3 Jul 2025, BALATON Zoltan wrote:
>>> Hello,
>> 
>> Ping? Do we have hw/ppc maintainers who can look at this and merge it?
>
> Apologies for the delay, things have been quite hectic here. I'll take a look 
> now.

Thank you, Just sent a v3 so make sure you look at that (although it's 
much the same).

Regards,
BALATON Zoltan
>> 
>>> This series cleans up and simplifies the raven model which does some
>>> strange stuff that no other pci-host is doing and does it in a
>>> convoluted way and also has some legacy bits that can be removed.
>>> Apart from making the model much more readable this also fixes the
>>> non-contiguous IO control bit which was there but did not work as it
>>> was not connected but apparently it's not really used by any guest so
>>> that wasn't noticed.
>>> 
>>> Regards,
>>> BALATON Zoltan
>>> 
>>> v2:
>>> - rebase on master
>>> - add R-b tags from Philippe
>>> 
>>> BALATON Zoltan (14):
>>>  hw/pci-host/raven: Simplify PCI facing part
>>>  hw/pci-host/raven: Simplify host bridge type declaration
>>>  hw/pci-host/raven: Use DEFINE_TYPES macro
>>>  hw/pci-host/raven: Simplify PCI bus creation
>>>  hw/pci-host/raven: Simplify PCI interrupt routing
>>>  hw/pci-host/raven: Simplify direct config access address decoding
>>>  hw/pci-host/raven: Rename direct config access ops
>>>  hw/pci-host/raven: Use correct parameter in direct access ops
>>>  hw/pci-host/raven: Do not use parent object for mmcfg region
>>>  hw/pci-host/raven: Fix PCI config direct access region
>>>  hw/pci-host/raven: Simpify discontiguous IO access
>>>  hw/pci-host/raven: Move bus master address space creation to one place
>>>  hw/pci-host/raven: Do not map regions in init method
>>>  hw/ppc/prep: Fix non-contiguous IO control bit
>>> 
>>> hw/pci-host/raven.c       | 328 ++++++++++++--------------------------
>>> hw/ppc/prep.c             |  19 ++-
>>> hw/ppc/prep_systemio.c    |  14 +-
>>> include/hw/pci/pci_host.h |   1 -
>>> 4 files changed, 127 insertions(+), 235 deletions(-)
>
>
> ATB,
>
> Mark.
>
>
>