[PATCH 2/3] hw/net/fsl_etsec: Set default MAC address

BALATON Zoltan posted 3 patches 5 months, 3 weeks ago
Maintainers: Bernhard Beschow <shentey@gmail.com>, Jason Wang <jasowang@redhat.com>
[PATCH 2/3] hw/net/fsl_etsec: Set default MAC address
Posted by BALATON Zoltan 5 months, 3 weeks ago
Use default MAC address if none is specified by property as done by
most other network interface models.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/net/fsl_etsec/etsec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index d14cb2a101..846f6cbc5d 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -389,6 +389,7 @@ static void etsec_realize(DeviceState *dev, Error **errp)
 {
     eTSEC        *etsec = ETSEC_COMMON(dev);
 
+    qemu_macaddr_default_if_unset(&etsec->conf.macaddr);
     etsec->nic = qemu_new_nic(&net_etsec_info, &etsec->conf,
                               object_get_typename(OBJECT(dev)), dev->id,
                               &dev->mem_reentrancy_guard, etsec);
-- 
2.41.3
Re: [PATCH 2/3] hw/net/fsl_etsec: Set default MAC address
Posted by Bernhard Beschow 5 months, 2 weeks ago

Am 23. Mai 2025 15:02:12 UTC schrieb BALATON Zoltan <balaton@eik.bme.hu>:
>Use default MAC address if none is specified by property as done by
>most other network interface models.
>
>Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>---
> hw/net/fsl_etsec/etsec.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
>index d14cb2a101..846f6cbc5d 100644
>--- a/hw/net/fsl_etsec/etsec.c
>+++ b/hw/net/fsl_etsec/etsec.c
>@@ -389,6 +389,7 @@ static void etsec_realize(DeviceState *dev, Error **errp)
> {
>     eTSEC        *etsec = ETSEC_COMMON(dev);
> 
>+    qemu_macaddr_default_if_unset(&etsec->conf.macaddr);
>     etsec->nic = qemu_new_nic(&net_etsec_info, &etsec->conf,
>                               object_get_typename(OBJECT(dev)), dev->id,
>                               &dev->mem_reentrancy_guard, etsec);

Reviewed-by: Bernhard Beschow <shentey@gmail.com>