[v2] scripts: render_block_graph: Fix with new python and improve argument parsing

[PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing

Posted by Peter Krempa 10 months, 3 weeks ago

New python doesn't like '\l' escapes from the 'dot' language.

While at it improve usability of the script by employing proper argument
parsing.

v2:
 - use mutually exclusive group instead of hardcoding it (Pavel)

Peter Krempa (3):
  scripts: render_block_graph: Fix invalid escape sequence warning with
    python 3.12
  scripts: render_block_graph: Implement proper argument parser
  scripts: render_block_graph: Avoid backtrace on error from virsh

 scripts/render_block_graph.py | 80 +++++++++++++++++++++++++----------
 1 file changed, 57 insertions(+), 23 deletions(-)

-- 
2.48.1

Re: [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing

Posted by Peter Krempa 8 months ago

On Wed, Mar 19, 2025 at 17:28:06 +0100, Peter Krempa wrote:
> New python doesn't like '\l' escapes from the 'dot' language.
> 
> While at it improve usability of the script by employing proper argument
> parsing.
> 
> v2:
>  - use mutually exclusive group instead of hardcoding it (Pavel)
> 
> Peter Krempa (3):
>   scripts: render_block_graph: Fix invalid escape sequence warning with
>     python 3.12
>   scripts: render_block_graph: Implement proper argument parser
>   scripts: render_block_graph: Avoid backtrace on error from virsh

Ping :)

Re: [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing

Posted by John Snow 8 months ago

On Tue, Jun 10, 2025 at 8:40 AM Peter Krempa <pkrempa@redhat.com> wrote:

> On Wed, Mar 19, 2025 at 17:28:06 +0100, Peter Krempa wrote:
> > New python doesn't like '\l' escapes from the 'dot' language.
> >
> > While at it improve usability of the script by employing proper argument
> > parsing.
> >
> > v2:
> >  - use mutually exclusive group instead of hardcoding it (Pavel)
> >
> > Peter Krempa (3):
> >   scripts: render_block_graph: Fix invalid escape sequence warning with
> >     python 3.12
> >   scripts: render_block_graph: Implement proper argument parser
> >   scripts: render_block_graph: Avoid backtrace on error from virsh
>
> Ping :)

Ah darn, guess that's me.

Tempted to just say "LGTM!" but lemme give it the once over here ... If you
don't hear back within a day or two just ping my email box directly to nag
me, please-and-thank-you.

--js

Re: [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing

Posted by Peter Krempa 1 month ago

On Tue, Jun 10, 2025 at 15:54:54 -0400, John Snow wrote:
> On Tue, Jun 10, 2025 at 8:40 AM Peter Krempa <pkrempa@redhat.com> wrote:
> 
> > On Wed, Mar 19, 2025 at 17:28:06 +0100, Peter Krempa wrote:
> > > New python doesn't like '\l' escapes from the 'dot' language.
> > >
> > > While at it improve usability of the script by employing proper argument
> > > parsing.
> > >
> > > v2:
> > >  - use mutually exclusive group instead of hardcoding it (Pavel)
> > >
> > > Peter Krempa (3):
> > >   scripts: render_block_graph: Fix invalid escape sequence warning with
> > >     python 3.12
> > >   scripts: render_block_graph: Implement proper argument parser
> > >   scripts: render_block_graph: Avoid backtrace on error from virsh
> >
> > Ping :)
> 
> 
> Ah darn, guess that's me.
> 
> Tempted to just say "LGTM!" but lemme give it the once over here ... If you
> don't hear back within a day or two just ping my email box directly to nag
> me, please-and-thank-you.

I guess I forgot to ping you :)

Re: [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing

Posted by Pavel Hrdina 10 months, 3 weeks ago

On Wed, Mar 19, 2025 at 05:28:06PM +0100, Peter Krempa wrote:
> New python doesn't like '\l' escapes from the 'dot' language.
> 
> While at it improve usability of the script by employing proper argument
> parsing.
> 
> v2:
>  - use mutually exclusive group instead of hardcoding it (Pavel)
> 
> Peter Krempa (3):
>   scripts: render_block_graph: Fix invalid escape sequence warning with
>     python 3.12
>   scripts: render_block_graph: Implement proper argument parser
>   scripts: render_block_graph: Avoid backtrace on error from virsh

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>