[v4] Drop ignore_memory_transaction_failures for xilink_zynq

[PATCH v4 0/3] Drop ignore_memory_transaction_failures for xilink_zynq

Posted by Chao Liu 2 weeks, 1 day ago

Hi, maintainer,

Following the reference from the chip manualug585-Zynq-7000-TRM manual
B.3 (Module Summary), placeholders have been added for all unimplemented
devices, including the AXI and AMBA bus controllers that interact with
the FPGA.

We can check against the manual by printing the address space of the
zynq board with the following qemu command:
    ${QEMU_PATH}/qemu-system-aarch64 \
    -M xilinx-zynq-a9 \
    -display none \
    -monitor stdio -s
    (qemu) info mtree -f

The testing methodology previously discussed in earlier email exchanges
will not be repeated here.

Chao Liu (3):
  xilink_zynq: Add various missing unimplemented devices
  xilink-zynq-devcfg: Fix up for memory address range size not set
    correctly
  xilink-zynq-devcfg: Avoid disabling devcfg memory region during
    initialization

 hw/arm/xilinx_zynq.c              | 71 ++++++++++++++++++++++++++++++-
 hw/dma/xlnx-zynq-devcfg.c         |  9 +++-
 include/hw/dma/xlnx-zynq-devcfg.h |  2 +-
 3 files changed, 78 insertions(+), 4 deletions(-)

-- 
2.46.1

Re: [PATCH v4 0/3] Drop ignore_memory_transaction_failures for xilink_zynq

Posted by Peter Maydell 1 week, 1 day ago

On Mon, 7 Oct 2024 at 12:25, Chao Liu <chao.liu@yeah.net> wrote:
>
> Hi, maintainer,
>
> Following the reference from the chip manualug585-Zynq-7000-TRM manual
> B.3 (Module Summary), placeholders have been added for all unimplemented
> devices, including the AXI and AMBA bus controllers that interact with
> the FPGA.
>
> We can check against the manual by printing the address space of the
> zynq board with the following qemu command:
>     ${QEMU_PATH}/qemu-system-aarch64 \
>     -M xilinx-zynq-a9 \
>     -display none \
>     -monitor stdio -s
>     (qemu) info mtree -f
>
> The testing methodology previously discussed in earlier email exchanges
> will not be repeated here.
>
> Chao Liu (3):
>   xilink_zynq: Add various missing unimplemented devices
>   xilink-zynq-devcfg: Fix up for memory address range size not set
>     correctly
>   xilink-zynq-devcfg: Avoid disabling devcfg memory region during
>     initialization

I've left comments for patches 2 and 3. I have taken patch 1
into target-arm.next, with the ignore_memory_transaction_failures
line reinstated.

I'm all in favour of our being able to get rid of that
legacy flag setting for this board, but as I've said on
previous versions of this patchset, we need to have
confidence that it's not going to break existing guest
code, which means the patch removing it needs to come
with a description of the testing that's been done
(which should be more than "Linux still boots").

thanks
-- PMM