[v1] Guestperf: miscellaneous refinement and enrichment

[PATCH v1 1/5] tests/migration: Move the guestperf tool to scripts directory

Posted by yong.huang@smartx.com 3 months, 2 weeks ago

From: Hyman Huang <yong.huang@smartx.com>

Guestperf was designed to test the performance of migration,
with a loose connection to the fundamental test cases of QEMU.

To improve the repository's structure, move it to the scripts
directory.

Signed-off-by: Hyman Huang <yong.huang@smartx.com>
---
 MAINTAINERS                                          | 5 +++++
 {tests => scripts}/migration/guestperf-batch.py      | 0
 {tests => scripts}/migration/guestperf-plot.py       | 0
 {tests => scripts}/migration/guestperf.py            | 0
 {tests => scripts}/migration/guestperf/__init__.py   | 0
 {tests => scripts}/migration/guestperf/comparison.py | 0
 {tests => scripts}/migration/guestperf/engine.py     | 0
 {tests => scripts}/migration/guestperf/hardware.py   | 0
 {tests => scripts}/migration/guestperf/plot.py       | 0
 {tests => scripts}/migration/guestperf/progress.py   | 0
 {tests => scripts}/migration/guestperf/report.py     | 0
 {tests => scripts}/migration/guestperf/scenario.py   | 0
 {tests => scripts}/migration/guestperf/shell.py      | 0
 {tests => scripts}/migration/guestperf/timings.py    | 0
 14 files changed, 5 insertions(+)
 rename {tests => scripts}/migration/guestperf-batch.py (100%)
 rename {tests => scripts}/migration/guestperf-plot.py (100%)
 rename {tests => scripts}/migration/guestperf.py (100%)
 rename {tests => scripts}/migration/guestperf/__init__.py (100%)
 rename {tests => scripts}/migration/guestperf/comparison.py (100%)
 rename {tests => scripts}/migration/guestperf/engine.py (100%)
 rename {tests => scripts}/migration/guestperf/hardware.py (100%)
 rename {tests => scripts}/migration/guestperf/plot.py (100%)
 rename {tests => scripts}/migration/guestperf/progress.py (100%)
 rename {tests => scripts}/migration/guestperf/report.py (100%)
 rename {tests => scripts}/migration/guestperf/scenario.py (100%)
 rename {tests => scripts}/migration/guestperf/shell.py (100%)
 rename {tests => scripts}/migration/guestperf/timings.py (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 10af212632..dae1535dae 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3449,6 +3449,11 @@ F: migration/dirtyrate.h
 F: include/sysemu/dirtyrate.h
 F: docs/devel/migration/dirty-limit.rst
 
+Migration performance test tool
+M: Hyman Huang <yong.huang@smartx.com>
+S: Maintained
+F: scripts/migration/
+
 Detached LUKS header
 M: Hyman Huang <yong.huang@smartx.com>
 S: Maintained
diff --git a/tests/migration/guestperf-batch.py b/scripts/migration/guestperf-batch.py
similarity index 100%
rename from tests/migration/guestperf-batch.py
rename to scripts/migration/guestperf-batch.py
diff --git a/tests/migration/guestperf-plot.py b/scripts/migration/guestperf-plot.py
similarity index 100%
rename from tests/migration/guestperf-plot.py
rename to scripts/migration/guestperf-plot.py
diff --git a/tests/migration/guestperf.py b/scripts/migration/guestperf.py
similarity index 100%
rename from tests/migration/guestperf.py
rename to scripts/migration/guestperf.py
diff --git a/tests/migration/guestperf/__init__.py b/scripts/migration/guestperf/__init__.py
similarity index 100%
rename from tests/migration/guestperf/__init__.py
rename to scripts/migration/guestperf/__init__.py
diff --git a/tests/migration/guestperf/comparison.py b/scripts/migration/guestperf/comparison.py
similarity index 100%
rename from tests/migration/guestperf/comparison.py
rename to scripts/migration/guestperf/comparison.py
diff --git a/tests/migration/guestperf/engine.py b/scripts/migration/guestperf/engine.py
similarity index 100%
rename from tests/migration/guestperf/engine.py
rename to scripts/migration/guestperf/engine.py
diff --git a/tests/migration/guestperf/hardware.py b/scripts/migration/guestperf/hardware.py
similarity index 100%
rename from tests/migration/guestperf/hardware.py
rename to scripts/migration/guestperf/hardware.py
diff --git a/tests/migration/guestperf/plot.py b/scripts/migration/guestperf/plot.py
similarity index 100%
rename from tests/migration/guestperf/plot.py
rename to scripts/migration/guestperf/plot.py
diff --git a/tests/migration/guestperf/progress.py b/scripts/migration/guestperf/progress.py
similarity index 100%
rename from tests/migration/guestperf/progress.py
rename to scripts/migration/guestperf/progress.py
diff --git a/tests/migration/guestperf/report.py b/scripts/migration/guestperf/report.py
similarity index 100%
rename from tests/migration/guestperf/report.py
rename to scripts/migration/guestperf/report.py
diff --git a/tests/migration/guestperf/scenario.py b/scripts/migration/guestperf/scenario.py
similarity index 100%
rename from tests/migration/guestperf/scenario.py
rename to scripts/migration/guestperf/scenario.py
diff --git a/tests/migration/guestperf/shell.py b/scripts/migration/guestperf/shell.py
similarity index 100%
rename from tests/migration/guestperf/shell.py
rename to scripts/migration/guestperf/shell.py
diff --git a/tests/migration/guestperf/timings.py b/scripts/migration/guestperf/timings.py
similarity index 100%
rename from tests/migration/guestperf/timings.py
rename to scripts/migration/guestperf/timings.py
-- 
2.11.0

Re: [PATCH v1 1/5] tests/migration: Move the guestperf tool to scripts directory

Posted by Fabiano Rosas 3 months, 2 weeks ago

yong.huang@smartx.com writes:

> From: Hyman Huang <yong.huang@smartx.com>
>
> Guestperf was designed to test the performance of migration,
> with a loose connection to the fundamental test cases of QEMU.
>
> To improve the repository's structure, move it to the scripts
> directory.
>
> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
> ---
>  MAINTAINERS                                          | 5 +++++
>  {tests => scripts}/migration/guestperf-batch.py      | 0
>  {tests => scripts}/migration/guestperf-plot.py       | 0
>  {tests => scripts}/migration/guestperf.py            | 0
>  {tests => scripts}/migration/guestperf/__init__.py   | 0
>  {tests => scripts}/migration/guestperf/comparison.py | 0
>  {tests => scripts}/migration/guestperf/engine.py     | 0
>  {tests => scripts}/migration/guestperf/hardware.py   | 0
>  {tests => scripts}/migration/guestperf/plot.py       | 0
>  {tests => scripts}/migration/guestperf/progress.py   | 0
>  {tests => scripts}/migration/guestperf/report.py     | 0
>  {tests => scripts}/migration/guestperf/scenario.py   | 0
>  {tests => scripts}/migration/guestperf/shell.py      | 0
>  {tests => scripts}/migration/guestperf/timings.py    | 0
>  14 files changed, 5 insertions(+)
>  rename {tests => scripts}/migration/guestperf-batch.py (100%)
>  rename {tests => scripts}/migration/guestperf-plot.py (100%)
>  rename {tests => scripts}/migration/guestperf.py (100%)
>  rename {tests => scripts}/migration/guestperf/__init__.py (100%)
>  rename {tests => scripts}/migration/guestperf/comparison.py (100%)
>  rename {tests => scripts}/migration/guestperf/engine.py (100%)
>  rename {tests => scripts}/migration/guestperf/hardware.py (100%)
>  rename {tests => scripts}/migration/guestperf/plot.py (100%)
>  rename {tests => scripts}/migration/guestperf/progress.py (100%)
>  rename {tests => scripts}/migration/guestperf/report.py (100%)
>  rename {tests => scripts}/migration/guestperf/scenario.py (100%)
>  rename {tests => scripts}/migration/guestperf/shell.py (100%)
>  rename {tests => scripts}/migration/guestperf/timings.py (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 10af212632..dae1535dae 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3449,6 +3449,11 @@ F: migration/dirtyrate.h
>  F: include/sysemu/dirtyrate.h
>  F: docs/devel/migration/dirty-limit.rst
>  
> +Migration performance test tool
> +M: Hyman Huang <yong.huang@smartx.com>
> +S: Maintained
> +F: scripts/migration/

This probably needs to be scripts/migration/guestperf* unless of course
you intend to maintain all scripts that show up under
scripts/migration/. We have analyze-migration.py and
vmstate-static-checker.py which are candidates to be put in that same
directory.

> +
>  Detached LUKS header
>  M: Hyman Huang <yong.huang@smartx.com>
>  S: Maintained
> diff --git a/tests/migration/guestperf-batch.py b/scripts/migration/guestperf-batch.py
> similarity index 100%
> rename from tests/migration/guestperf-batch.py
> rename to scripts/migration/guestperf-batch.py
> diff --git a/tests/migration/guestperf-plot.py b/scripts/migration/guestperf-plot.py
> similarity index 100%
> rename from tests/migration/guestperf-plot.py
> rename to scripts/migration/guestperf-plot.py
> diff --git a/tests/migration/guestperf.py b/scripts/migration/guestperf.py
> similarity index 100%
> rename from tests/migration/guestperf.py
> rename to scripts/migration/guestperf.py
> diff --git a/tests/migration/guestperf/__init__.py b/scripts/migration/guestperf/__init__.py
> similarity index 100%
> rename from tests/migration/guestperf/__init__.py
> rename to scripts/migration/guestperf/__init__.py
> diff --git a/tests/migration/guestperf/comparison.py b/scripts/migration/guestperf/comparison.py
> similarity index 100%
> rename from tests/migration/guestperf/comparison.py
> rename to scripts/migration/guestperf/comparison.py
> diff --git a/tests/migration/guestperf/engine.py b/scripts/migration/guestperf/engine.py
> similarity index 100%
> rename from tests/migration/guestperf/engine.py
> rename to scripts/migration/guestperf/engine.py
> diff --git a/tests/migration/guestperf/hardware.py b/scripts/migration/guestperf/hardware.py
> similarity index 100%
> rename from tests/migration/guestperf/hardware.py
> rename to scripts/migration/guestperf/hardware.py
> diff --git a/tests/migration/guestperf/plot.py b/scripts/migration/guestperf/plot.py
> similarity index 100%
> rename from tests/migration/guestperf/plot.py
> rename to scripts/migration/guestperf/plot.py
> diff --git a/tests/migration/guestperf/progress.py b/scripts/migration/guestperf/progress.py
> similarity index 100%
> rename from tests/migration/guestperf/progress.py
> rename to scripts/migration/guestperf/progress.py
> diff --git a/tests/migration/guestperf/report.py b/scripts/migration/guestperf/report.py
> similarity index 100%
> rename from tests/migration/guestperf/report.py
> rename to scripts/migration/guestperf/report.py
> diff --git a/tests/migration/guestperf/scenario.py b/scripts/migration/guestperf/scenario.py
> similarity index 100%
> rename from tests/migration/guestperf/scenario.py
> rename to scripts/migration/guestperf/scenario.py
> diff --git a/tests/migration/guestperf/shell.py b/scripts/migration/guestperf/shell.py
> similarity index 100%
> rename from tests/migration/guestperf/shell.py
> rename to scripts/migration/guestperf/shell.py
> diff --git a/tests/migration/guestperf/timings.py b/scripts/migration/guestperf/timings.py
> similarity index 100%
> rename from tests/migration/guestperf/timings.py
> rename to scripts/migration/guestperf/timings.py

Re: [PATCH v1 1/5] tests/migration: Move the guestperf tool to scripts directory

Posted by Hyman Huang 3 months, 2 weeks ago

在 2024/8/9 20:57, Fabiano Rosas 写道:
> yong.huang@smartx.com writes:
>
>> From: Hyman Huang <yong.huang@smartx.com>
>>
>> Guestperf was designed to test the performance of migration,
>> with a loose connection to the fundamental test cases of QEMU.
>>
>> To improve the repository's structure, move it to the scripts
>> directory.
>>
>> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
>> ---
>>   MAINTAINERS                                          | 5 +++++
>>   {tests => scripts}/migration/guestperf-batch.py      | 0
>>   {tests => scripts}/migration/guestperf-plot.py       | 0
>>   {tests => scripts}/migration/guestperf.py            | 0
>>   {tests => scripts}/migration/guestperf/__init__.py   | 0
>>   {tests => scripts}/migration/guestperf/comparison.py | 0
>>   {tests => scripts}/migration/guestperf/engine.py     | 0
>>   {tests => scripts}/migration/guestperf/hardware.py   | 0
>>   {tests => scripts}/migration/guestperf/plot.py       | 0
>>   {tests => scripts}/migration/guestperf/progress.py   | 0
>>   {tests => scripts}/migration/guestperf/report.py     | 0
>>   {tests => scripts}/migration/guestperf/scenario.py   | 0
>>   {tests => scripts}/migration/guestperf/shell.py      | 0
>>   {tests => scripts}/migration/guestperf/timings.py    | 0
>>   14 files changed, 5 insertions(+)
>>   rename {tests => scripts}/migration/guestperf-batch.py (100%)
>>   rename {tests => scripts}/migration/guestperf-plot.py (100%)
>>   rename {tests => scripts}/migration/guestperf.py (100%)
>>   rename {tests => scripts}/migration/guestperf/__init__.py (100%)
>>   rename {tests => scripts}/migration/guestperf/comparison.py (100%)
>>   rename {tests => scripts}/migration/guestperf/engine.py (100%)
>>   rename {tests => scripts}/migration/guestperf/hardware.py (100%)
>>   rename {tests => scripts}/migration/guestperf/plot.py (100%)
>>   rename {tests => scripts}/migration/guestperf/progress.py (100%)
>>   rename {tests => scripts}/migration/guestperf/report.py (100%)
>>   rename {tests => scripts}/migration/guestperf/scenario.py (100%)
>>   rename {tests => scripts}/migration/guestperf/shell.py (100%)
>>   rename {tests => scripts}/migration/guestperf/timings.py (100%)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 10af212632..dae1535dae 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3449,6 +3449,11 @@ F: migration/dirtyrate.h
>>   F: include/sysemu/dirtyrate.h
>>   F: docs/devel/migration/dirty-limit.rst
>>   
>> +Migration performance test tool
>> +M: Hyman Huang <yong.huang@smartx.com>
>> +S: Maintained
>> +F: scripts/migration/
> This probably needs to be scripts/migration/guestperf* unless of course
> you intend to maintain all scripts that show up under
> scripts/migration/. We have analyze-migration.py and
> vmstate-static-checker.py which are candidates to be put in that same
> directory.

Ok, I'll update this section in the next version.

>
>> +
>>   Detached LUKS header
>>   M: Hyman Huang <yong.huang@smartx.com>
>>   S: Maintained
>> diff --git a/tests/migration/guestperf-batch.py b/scripts/migration/guestperf-batch.py
>> similarity index 100%
>> rename from tests/migration/guestperf-batch.py
>> rename to scripts/migration/guestperf-batch.py
>> diff --git a/tests/migration/guestperf-plot.py b/scripts/migration/guestperf-plot.py
>> similarity index 100%
>> rename from tests/migration/guestperf-plot.py
>> rename to scripts/migration/guestperf-plot.py
>> diff --git a/tests/migration/guestperf.py b/scripts/migration/guestperf.py
>> similarity index 100%
>> rename from tests/migration/guestperf.py
>> rename to scripts/migration/guestperf.py
>> diff --git a/tests/migration/guestperf/__init__.py b/scripts/migration/guestperf/__init__.py
>> similarity index 100%
>> rename from tests/migration/guestperf/__init__.py
>> rename to scripts/migration/guestperf/__init__.py
>> diff --git a/tests/migration/guestperf/comparison.py b/scripts/migration/guestperf/comparison.py
>> similarity index 100%
>> rename from tests/migration/guestperf/comparison.py
>> rename to scripts/migration/guestperf/comparison.py
>> diff --git a/tests/migration/guestperf/engine.py b/scripts/migration/guestperf/engine.py
>> similarity index 100%
>> rename from tests/migration/guestperf/engine.py
>> rename to scripts/migration/guestperf/engine.py
>> diff --git a/tests/migration/guestperf/hardware.py b/scripts/migration/guestperf/hardware.py
>> similarity index 100%
>> rename from tests/migration/guestperf/hardware.py
>> rename to scripts/migration/guestperf/hardware.py
>> diff --git a/tests/migration/guestperf/plot.py b/scripts/migration/guestperf/plot.py
>> similarity index 100%
>> rename from tests/migration/guestperf/plot.py
>> rename to scripts/migration/guestperf/plot.py
>> diff --git a/tests/migration/guestperf/progress.py b/scripts/migration/guestperf/progress.py
>> similarity index 100%
>> rename from tests/migration/guestperf/progress.py
>> rename to scripts/migration/guestperf/progress.py
>> diff --git a/tests/migration/guestperf/report.py b/scripts/migration/guestperf/report.py
>> similarity index 100%
>> rename from tests/migration/guestperf/report.py
>> rename to scripts/migration/guestperf/report.py
>> diff --git a/tests/migration/guestperf/scenario.py b/scripts/migration/guestperf/scenario.py
>> similarity index 100%
>> rename from tests/migration/guestperf/scenario.py
>> rename to scripts/migration/guestperf/scenario.py
>> diff --git a/tests/migration/guestperf/shell.py b/scripts/migration/guestperf/shell.py
>> similarity index 100%
>> rename from tests/migration/guestperf/shell.py
>> rename to scripts/migration/guestperf/shell.py
>> diff --git a/tests/migration/guestperf/timings.py b/scripts/migration/guestperf/timings.py
>> similarity index 100%
>> rename from tests/migration/guestperf/timings.py
>> rename to scripts/migration/guestperf/timings.py

[PATCH v1 1/5] tests/migration: Move the guestperf tool to scripts directory
[PATCH v1 2/5] tests/migration: Make initrd-stress.img built by default
[PATCH v1 3/5] guestperf: Support deferred migration for multifd
[PATCH v1 4/5] guestperf: Nitpick the inconsistent parameters
[PATCH v1 5/5] guestperf: Introduce multifd compression option