Consolidate embedded PPC initial mappung functions

[PATCH 0/2] Consolidate embedded PPC initial mappung functions

BALATON Zoltan posted 2 patches 1 month, 3 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1721131193.git.balaton@eik.bme.hu

Maintainers: Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, BALATON Zoltan <balaton@eik.bme.hu>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

hw/ppc/e500.c          | 41 ++++++++++++++++++--------------------
hw/ppc/e500.h          |  2 --
hw/ppc/ppc440_bamboo.c | 28 +++-----------------------
hw/ppc/ppc_booke.c     | 10 ++++++++++
hw/ppc/ppce500_spin.c  | 30 +++++++++-------------------
hw/ppc/sam460ex.c      | 45 ++++++++++--------------------------------
hw/ppc/virtex_ml507.c  | 28 +++-----------------------
include/hw/ppc/ppc.h   |  7 +++++++
8 files changed, 61 insertions(+), 130 deletions(-)

Expand all Fold all

[PATCH 0/2] Consolidate embedded PPC initial mappung functions

Posted by BALATON Zoltan 1 month, 3 weeks ago

Embedded PPC has always enabled MMU so it needs initial mappings to
start. This code is duplicated within machines which this small series
aims to consolidate into helper functions to reduce duplicated code
and make the board code simpler.

Regards,
BALATON Zoltan

BALATON Zoltan (2):
  hw/ppc: Consolidate e500 initial mapping creation functions
  hw/ppc: Consolidate ppc440 initial mapping creation functions

 hw/ppc/e500.c          | 41 ++++++++++++++++++--------------------
 hw/ppc/e500.h          |  2 --
 hw/ppc/ppc440_bamboo.c | 28 +++-----------------------
 hw/ppc/ppc_booke.c     | 10 ++++++++++
 hw/ppc/ppce500_spin.c  | 30 +++++++++-------------------
 hw/ppc/sam460ex.c      | 45 ++++++++++--------------------------------
 hw/ppc/virtex_ml507.c  | 28 +++-----------------------
 include/hw/ppc/ppc.h   |  7 +++++++
 8 files changed, 61 insertions(+), 130 deletions(-)

-- 
2.30.9

Re: [PATCH 0/2] Consolidate embedded PPC initial mappung functions

Posted by Edgar E. Iglesias 1 month, 3 weeks ago

On Tue, Jul 16, 2024 at 02:07:56PM +0200, BALATON Zoltan wrote:
> Embedded PPC has always enabled MMU so it needs initial mappings to
> start. This code is duplicated within machines which this small series
> aims to consolidate into helper functions to reduce duplicated code
> and make the board code simpler.
> 
> Regards,
> BALATON Zoltan

I tested this with my virtex-ml507 images:

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Tested-by: Edgar E. Iglesias <edgar.iglesias@amd.com>

Cheers,
Edgar


> 
> BALATON Zoltan (2):
>   hw/ppc: Consolidate e500 initial mapping creation functions
>   hw/ppc: Consolidate ppc440 initial mapping creation functions
> 
>  hw/ppc/e500.c          | 41 ++++++++++++++++++--------------------
>  hw/ppc/e500.h          |  2 --
>  hw/ppc/ppc440_bamboo.c | 28 +++-----------------------
>  hw/ppc/ppc_booke.c     | 10 ++++++++++
>  hw/ppc/ppce500_spin.c  | 30 +++++++++-------------------
>  hw/ppc/sam460ex.c      | 45 ++++++++++--------------------------------
>  hw/ppc/virtex_ml507.c  | 28 +++-----------------------
>  include/hw/ppc/ppc.h   |  7 +++++++
>  8 files changed, 61 insertions(+), 130 deletions(-)
> 
> -- 
> 2.30.9
>