On Mon May 27, 2024 at 9:12 AM AEST, BALATON Zoltan wrote:
> In mmu6xx_get_physical_address() tagtet_page_bits local is declared
> only to use TARGET_PAGE_BITS once. Drop the unneeded variable.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> target/ppc/mmu_common.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
> index 5145bde7f9..0152e8d875 100644
> --- a/target/ppc/mmu_common.c
> +++ b/target/ppc/mmu_common.c
> @@ -321,7 +321,6 @@ static int mmu6xx_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx,
> PowerPCCPU *cpu = env_archcpu(env);
> hwaddr hash;
> target_ulong vsid, sr, pgidx;
> - int target_page_bits;
> bool pr, ds, nx;
>
> /* First try to find a BAT entry if there are any */
> @@ -338,7 +337,6 @@ static int mmu6xx_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx,
> ds = sr & SR32_T;
> nx = sr & SR32_NX;
> vsid = sr & SR32_VSID;
> - target_page_bits = TARGET_PAGE_BITS;
> qemu_log_mask(CPU_LOG_MMU,
> "Check segment v=" TARGET_FMT_lx " %d " TARGET_FMT_lx
> " nip=" TARGET_FMT_lx " lr=" TARGET_FMT_lx
> @@ -347,7 +345,7 @@ static int mmu6xx_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx,
> (int)FIELD_EX64(env->msr, MSR, IR),
> (int)FIELD_EX64(env->msr, MSR, DR), pr ? 1 : 0,
> access_type == MMU_DATA_STORE, type);
> - pgidx = (eaddr & ~SEGMENT_MASK_256M) >> target_page_bits;
> + pgidx = (eaddr & ~SEGMENT_MASK_256M) >> TARGET_PAGE_BITS;
> hash = vsid ^ pgidx;
> ctx->ptem = (vsid << 7) | (pgidx >> 10);
>