[PATCH v3 0/3] Adjust the output of x-query-virtio-status

Hyman Huang posted 3 patches 9 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1706883915.git.yong.huang@smartx.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>
There is a newer version of this series
hw/virtio/meson.build       |   3 +-
hw/virtio/virtio-hmp-cmds.c | 702 +++++++++++++++++++++++++++++++++++-
hw/virtio/virtio-qmp.c      | 684 +----------------------------------
hw/virtio/virtio-qmp.h      |   3 -
qapi/virtio.json            | 231 +-----------
5 files changed, 723 insertions(+), 900 deletions(-)
[PATCH v3 0/3] Adjust the output of x-query-virtio-status
Posted by Hyman Huang 9 months, 3 weeks ago
Sorry for the late post of version 3. The modifications are as follows:

v3:
- Rebase on master
- Use the refined commit message furnished by Markus for [PATCH v2 1/2] 
- Drop the [PATCH v2 2/2]
- Add [PATCH v3 2/3] to declare the decoding functions to static
- Add [PATCH v3 3/3] to Define VhostDeviceProtocols and
  VirtioDeviceFeatures as plain C types

Since Markus inspired all of the alterations above, we would like to
thank him for his contribution to this series.

Please review,
Yong

v2:
- Changing the hmp_virtio_dump_xxx function signatures to implement
  the bitmap decoding, suggested by Philippe. 

This patchset is derived from the series:
https://lore.kernel.org/qemu-devel/cover.1699793550.git.yong.huang@smartx.com/
Please go to the link to see more background information.

The following points are what we have done in the patchset:
1. Take the policy of adding human-readable output just in HMP.
2. For the HMP output, display the human-readable information and
   drop the unknown bits in practice.
3. For the QMP output, remove the descriptive strings and only
   display bits encoded as numbers.

Hyman Huang (3):
  qmp: Switch x-query-virtio-status back to numeric encoding
  virtio: Declare the decoding functions to static
  qapi: Define VhostDeviceProtocols and VirtioDeviceFeatures as plain C
    types

 hw/virtio/meson.build       |   3 +-
 hw/virtio/virtio-hmp-cmds.c | 702 +++++++++++++++++++++++++++++++++++-
 hw/virtio/virtio-qmp.c      | 684 +----------------------------------
 hw/virtio/virtio-qmp.h      |   3 -
 qapi/virtio.json            | 231 +-----------
 5 files changed, 723 insertions(+), 900 deletions(-)

-- 
2.31.1
Re: [PATCH v3 0/3] Adjust the output of x-query-virtio-status
Posted by Michael S. Tsirkin 9 months, 2 weeks ago
On Fri, Feb 02, 2024 at 10:32:14PM +0800, Hyman Huang wrote:
> Sorry for the late post of version 3. The modifications are as follows:
> 
> v3:
> - Rebase on master
> - Use the refined commit message furnished by Markus for [PATCH v2 1/2] 
> - Drop the [PATCH v2 2/2]
> - Add [PATCH v3 2/3] to declare the decoding functions to static
> - Add [PATCH v3 3/3] to Define VhostDeviceProtocols and
>   VirtioDeviceFeatures as plain C types
> 
> Since Markus inspired all of the alterations above, we would like to
> thank him for his contribution to this series.
> 
> Please review,
> Yong

Markus do you think you can take a look at this?

> v2:
> - Changing the hmp_virtio_dump_xxx function signatures to implement
>   the bitmap decoding, suggested by Philippe. 
> 
> This patchset is derived from the series:
> https://lore.kernel.org/qemu-devel/cover.1699793550.git.yong.huang@smartx.com/
> Please go to the link to see more background information.
> 
> The following points are what we have done in the patchset:
> 1. Take the policy of adding human-readable output just in HMP.
> 2. For the HMP output, display the human-readable information and
>    drop the unknown bits in practice.
> 3. For the QMP output, remove the descriptive strings and only
>    display bits encoded as numbers.
> 
> Hyman Huang (3):
>   qmp: Switch x-query-virtio-status back to numeric encoding
>   virtio: Declare the decoding functions to static
>   qapi: Define VhostDeviceProtocols and VirtioDeviceFeatures as plain C
>     types
> 
>  hw/virtio/meson.build       |   3 +-
>  hw/virtio/virtio-hmp-cmds.c | 702 +++++++++++++++++++++++++++++++++++-
>  hw/virtio/virtio-qmp.c      | 684 +----------------------------------
>  hw/virtio/virtio-qmp.h      |   3 -
>  qapi/virtio.json            | 231 +-----------
>  5 files changed, 723 insertions(+), 900 deletions(-)
> 
> -- 
> 2.31.1
Re: [PATCH v3 0/3] Adjust the output of x-query-virtio-status
Posted by Markus Armbruster 9 months, 2 weeks ago
"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Fri, Feb 02, 2024 at 10:32:14PM +0800, Hyman Huang wrote:
>> Sorry for the late post of version 3. The modifications are as follows:
>> 
>> v3:
>> - Rebase on master
>> - Use the refined commit message furnished by Markus for [PATCH v2 1/2] 
>> - Drop the [PATCH v2 2/2]
>> - Add [PATCH v3 2/3] to declare the decoding functions to static
>> - Add [PATCH v3 3/3] to Define VhostDeviceProtocols and
>>   VirtioDeviceFeatures as plain C types
>> 
>> Since Markus inspired all of the alterations above, we would like to
>> thank him for his contribution to this series.
>> 
>> Please review,
>> Yong
>
> Markus do you think you can take a look at this?

I intend to.  Sorry for the delay!