[v1] hw/block/block.c: improve confusing error

[PATCH 0/2] hw/block/block.c: improve confusing error

Manos Pitsidianakis posted 2 patches 10 months, 1 week ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1705938003.git.manos.pitsidianakis@linaro.org

Maintainers: John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Alistair Francis <alistair@alistair23.me>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>

There is a newer version of this series

hw/block/block.c         | 25 +++++++++++++++----------
hw/block/m25p80.c        |  3 ++-
hw/block/pflash_cfi01.c  |  4 ++--
hw/block/pflash_cfi02.c  |  2 +-
hw/core/qdev.c           | 10 ++++++++++
include/hw/block/block.h |  4 ++--
include/hw/qdev-core.h   | 15 +++++++++++++++
7 files changed, 47 insertions(+), 16 deletions(-)

Expand all Fold all

[PATCH 0/2] hw/block/block.c: improve confusing error

Posted by Manos Pitsidianakis 10 months, 1 week ago

In cases where a device tries to read more bytes than the block device 
contains with the blk_check_size_and_read_all() function, the error is 
vague: "device requires X bytes, block backend provides Y bytes".

This patch changes the errors of this function to include the block
backend name, the device id and device type name where appropriate.

Manos Pitsidianakis (2):
  hw/core/qdev.c: add qdev_get_human_name()
  hw/block/block.c: improve confusing blk_check_size_and_read_all()
    error

 hw/block/block.c         | 25 +++++++++++++++----------
 hw/block/m25p80.c        |  3 ++-
 hw/block/pflash_cfi01.c  |  4 ++--
 hw/block/pflash_cfi02.c  |  2 +-
 hw/core/qdev.c           | 10 ++++++++++
 include/hw/block/block.h |  4 ++--
 include/hw/qdev-core.h   | 15 +++++++++++++++
 7 files changed, 47 insertions(+), 16 deletions(-)


base-commit: 09be34717190c1620f0c6e5c8765b8da354aeb4b
-- 
γαῖα πυρί μιχθήτω