[v5] Misc clean ups to target/ppc exception handling

[PATCH v5 7/9] target/ppc: Clean up ifdefs in excp_helper.c, part 2

Posted by BALATON Zoltan 10 months, 1 week ago

Remove check for !defined(CONFIG_USER_ONLY) as this is already within
an #ifndef CONFIG_USER_ONLY block.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 target/ppc/excp_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index d8eab4ff6c..2d4a72883f 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -2607,7 +2607,7 @@ void helper_hrfid(CPUPPCState *env)
 }
 #endif /* TARGET_PPC64 */
 
-#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY)
+#ifdef TARGET_PPC64
 void helper_rfebb(CPUPPCState *env, target_ulong s)
 {
     target_ulong msr = env->msr;
@@ -2682,7 +2682,7 @@ void raise_ebb_perfm_exception(CPUPPCState *env)
 
     do_ebb(env, POWERPC_EXCP_PERFM_EBB);
 }
-#endif /* defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) */
+#endif /* TARGET_PPC64 */
 
 /*****************************************************************************/
 /* Embedded PowerPC specific helpers */
-- 
2.30.9

Re: [PATCH v5 7/9] target/ppc: Clean up ifdefs in excp_helper.c, part 2

Posted by Harsh Prateek Bora 9 months, 1 week ago


On 1/19/24 03:31, BALATON Zoltan wrote:
> Remove check for !defined(CONFIG_USER_ONLY) as this is already within
> an #ifndef CONFIG_USER_ONLY block.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

> ---
>   target/ppc/excp_helper.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index d8eab4ff6c..2d4a72883f 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2607,7 +2607,7 @@ void helper_hrfid(CPUPPCState *env)
>   }
>   #endif /* TARGET_PPC64 */
>   
> -#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY)
> +#ifdef TARGET_PPC64
>   void helper_rfebb(CPUPPCState *env, target_ulong s)
>   {
>       target_ulong msr = env->msr;
> @@ -2682,7 +2682,7 @@ void raise_ebb_perfm_exception(CPUPPCState *env)
>   
>       do_ebb(env, POWERPC_EXCP_PERFM_EBB);
>   }
> -#endif /* defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) */
> +#endif /* TARGET_PPC64 */
>   
>   /*****************************************************************************/
>   /* Embedded PowerPC specific helpers */