[v1] block: commit/stream: Allow users to request only format driver names in backing file format

[PATCH 0/2] block: commit/stream: Allow users to request only format driver names in backing file format

Peter Krempa posted 2 patches 1 year ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1700837066.git.pkrempa@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

block.c                                | 37 +++++++++++++++++++++-----
block/commit.c                         |  6 ++++-
block/monitor/block-hmp-cmds.c         |  2 +-
block/stream.c                         | 10 ++++++-
blockdev.c                             | 13 +++++++++
include/block/block-global-state.h     |  3 ++-
include/block/block_int-common.h       |  4 ++-
include/block/block_int-global-state.h |  6 +++++
qapi/block-core.json                   | 22 +++++++++++++--
tests/unit/test-bdrv-drain.c           |  3 ++-
10 files changed, 91 insertions(+), 15 deletions(-)

Expand all Fold all

[PATCH 0/2] block: commit/stream: Allow users to request only format driver names in backing file format

Posted by Peter Krempa 1 year ago

Please see patches for rationale.

Libvirt patches using this new flag will be posted soon-ish (after
cleanup).

Peter Krempa (2):
  block: commit: Allow users to request only format driver names in
    backing file format
  block: stream: Allow users to request only format driver names in
    backing file format

 block.c                                | 37 +++++++++++++++++++++-----
 block/commit.c                         |  6 ++++-
 block/monitor/block-hmp-cmds.c         |  2 +-
 block/stream.c                         | 10 ++++++-
 blockdev.c                             | 13 +++++++++
 include/block/block-global-state.h     |  3 ++-
 include/block/block_int-common.h       |  4 ++-
 include/block/block_int-global-state.h |  6 +++++
 qapi/block-core.json                   | 22 +++++++++++++--
 tests/unit/test-bdrv-drain.c           |  3 ++-
 10 files changed, 91 insertions(+), 15 deletions(-)

-- 
2.43.0

Re: [PATCH 0/2] block: commit/stream: Allow users to request only format driver names in backing file format

Posted by Vladimir Sementsov-Ogievskiy 12 months ago

On 24.11.23 17:52, Peter Krempa wrote:
> Please see patches for rationale.
> 
> Libvirt patches using this new flag will be posted soon-ish (after
> cleanup).
> 
> Peter Krempa (2):
>    block: commit: Allow users to request only format driver names in
>      backing file format
>    block: stream: Allow users to request only format driver names in
>      backing file format
> 
>   block.c                                | 37 +++++++++++++++++++++-----
>   block/commit.c                         |  6 ++++-
>   block/monitor/block-hmp-cmds.c         |  2 +-
>   block/stream.c                         | 10 ++++++-
>   blockdev.c                             | 13 +++++++++
>   include/block/block-global-state.h     |  3 ++-
>   include/block/block_int-common.h       |  4 ++-
>   include/block/block_int-global-state.h |  6 +++++
>   qapi/block-core.json                   | 22 +++++++++++++--
>   tests/unit/test-bdrv-drain.c           |  3 ++-
>   10 files changed, 91 insertions(+), 15 deletions(-)
> 

Now seems good to me. Still:

1. Will need to update "since: 8.2" to 9, right?

2. Probably, use some shorter name... But I don't have good suggestion. Wouldn't that become a longest name in QAPI?)

-- 
Best regards,
Vladimir