[v1] Adds CPU hot-plug support to Loongarch

[PATCH 8/8] Turn on CPU hot-(un)plug customization for loongarch

Posted by xianglai li 2 years, 6 months ago

Turn on CPU hot-(un)plug custom for loongarch in the configuration file

Cc: Xiaojuan Yang <yangxiaojuan@loongson.cn>
Cc: Song Gao <gaosong@loongson.cn>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Ani Sinha <anisinha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Eduardo Habkost <eduardo@habkost.net>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Yanan Wang <wangyanan55@huawei.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: xianglai li <lixianglai@loongson.cn>
---
 configs/devices/loongarch64-softmmu/default.mak | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/devices/loongarch64-softmmu/default.mak b/configs/devices/loongarch64-softmmu/default.mak
index 928bc117ef..e596706fab 100644
--- a/configs/devices/loongarch64-softmmu/default.mak
+++ b/configs/devices/loongarch64-softmmu/default.mak
@@ -1,3 +1,4 @@
 # Default configuration for loongarch64-softmmu
 
 CONFIG_LOONGARCH_VIRT=y
+CONFIG_ACPI_CPU_HOTPLUG=y
-- 
2.39.1

Re: [PATCH 8/8] Turn on CPU hot-(un)plug customization for loongarch

Posted by Igor Mammedov 2 years, 6 months ago

On Thu, 20 Jul 2023 15:15:13 +0800
xianglai li <lixianglai@loongson.cn> wrote:

> Turn on CPU hot-(un)plug custom for loongarch in the configuration file
> 
> Cc: Xiaojuan Yang <yangxiaojuan@loongson.cn>
> Cc: Song Gao <gaosong@loongson.cn>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Ani Sinha <anisinha@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Eduardo Habkost <eduardo@habkost.net>
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
> Cc: Yanan Wang <wangyanan55@huawei.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: David Hildenbrand <david@redhat.com>
> Signed-off-by: xianglai li <lixianglai@loongson.cn>
> ---
>  configs/devices/loongarch64-softmmu/default.mak | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/devices/loongarch64-softmmu/default.mak b/configs/devices/loongarch64-softmmu/default.mak
> index 928bc117ef..e596706fab 100644
> --- a/configs/devices/loongarch64-softmmu/default.mak
> +++ b/configs/devices/loongarch64-softmmu/default.mak
> @@ -1,3 +1,4 @@
>  # Default configuration for loongarch64-softmmu
>  
>  CONFIG_LOONGARCH_VIRT=y
> +CONFIG_ACPI_CPU_HOTPLUG=y
this likely shall be part of prior patch (one that starts to use generic cpu hotplug functions)
otherwise you risk a broke bisection in the middle of series
(aka try to build series after applying each patch)

Re: [PATCH 8/8] Turn on CPU hot-(un)plug customization for loongarch

Posted by lixianglai 2 years, 6 months ago

Hi, Igor Mammedov:


On 7/28/23 9:30 PM, Igor Mammedov wrote:
> On Thu, 20 Jul 2023 15:15:13 +0800
> xianglai li <lixianglai@loongson.cn> wrote:
>
>> Turn on CPU hot-(un)plug custom for loongarch in the configuration file
>>
>> Cc: Xiaojuan Yang <yangxiaojuan@loongson.cn>
>> Cc: Song Gao <gaosong@loongson.cn>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Ani Sinha <anisinha@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Richard Henderson <richard.henderson@linaro.org>
>> Cc: Eduardo Habkost <eduardo@habkost.net>
>> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>> Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
>> Cc: Yanan Wang <wangyanan55@huawei.com>
>> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
>> Cc: Peter Xu <peterx@redhat.com>
>> Cc: David Hildenbrand <david@redhat.com>
>> Signed-off-by: xianglai li <lixianglai@loongson.cn>
>> ---
>>   configs/devices/loongarch64-softmmu/default.mak | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/devices/loongarch64-softmmu/default.mak b/configs/devices/loongarch64-softmmu/default.mak
>> index 928bc117ef..e596706fab 100644
>> --- a/configs/devices/loongarch64-softmmu/default.mak
>> +++ b/configs/devices/loongarch64-softmmu/default.mak
>> @@ -1,3 +1,4 @@
>>   # Default configuration for loongarch64-softmmu
>>   
>>   CONFIG_LOONGARCH_VIRT=y
>> +CONFIG_ACPI_CPU_HOTPLUG=y
> this likely shall be part of prior patch (one that starts to use generic cpu hotplug functions)
> otherwise you risk a broke bisection in the middle of series
> (aka try to build series after applying each patch)


Do you mean this patch should be inside the first patch?

Thanks,

xianglai

>

[PATCH 1/8] Update ACPI GED framework to support vcpu hot-(un)plug
[PATCH 2/8] Update CPUs AML with cpu-(ctrl)dev change
[PATCH 3/8] Introduced a new function to disconnect GPIO connections
[PATCH 4/8] Introduce the CPU address space destruction function
[PATCH 5/8] Adds basic CPU hot-(un)plug support for Loongarch
[PATCH 6/8] Add support of *unrealize* for loongarch cpu
[PATCH 7/8] Update the ACPI table for the Loongarch CPU
[PATCH 8/8] Turn on CPU hot-(un)plug customization for loongarch