[v2] mac_nvram: Add block backend to persist NVRAM contents

[PATCH v2 0/2] mac_nvram: Add block backend to persist NVRAM contents

BALATON Zoltan posted 2 patches 1 year, 7 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1675297286.git.balaton@eik.bme.hu

Maintainers: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

hw/nvram/mac_nvram.c         | 28 ++++++++++++++++++++++++++++
hw/ppc/mac_oldworld.c        |  8 +++++++-
include/hw/nvram/mac_nvram.h |  1 +
3 files changed, 36 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2 0/2] mac_nvram: Add block backend to persist NVRAM contents

Posted by BALATON Zoltan 1 year, 7 months ago

Same as v1 just split in two patches as suggested by Mark.

Regards,
BALATON Zoltan

BALATON Zoltan (2):
  mac_nvram: Add block backend to persist NVRAM contents
  mac_oldworld: Allow specifying nvram backing store

 hw/nvram/mac_nvram.c         | 28 ++++++++++++++++++++++++++++
 hw/ppc/mac_oldworld.c        |  8 +++++++-
 include/hw/nvram/mac_nvram.h |  1 +
 3 files changed, 36 insertions(+), 1 deletion(-)

-- 
2.30.6

Re: [PATCH v2 0/2] mac_nvram: Add block backend to persist NVRAM contents

Posted by Mark Cave-Ayland 1 year, 7 months ago

On 02/02/2023 00:24, BALATON Zoltan wrote:

> Same as v1 just split in two patches as suggested by Mark.
> 
> Regards,
> BALATON Zoltan
> 
> BALATON Zoltan (2):
>    mac_nvram: Add block backend to persist NVRAM contents
>    mac_oldworld: Allow specifying nvram backing store
> 
>   hw/nvram/mac_nvram.c         | 28 ++++++++++++++++++++++++++++
>   hw/ppc/mac_oldworld.c        |  8 +++++++-
>   include/hw/nvram/mac_nvram.h |  1 +
>   3 files changed, 36 insertions(+), 1 deletion(-)

This seems okay to me so:

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

There was no further comment from Cédric regarding blk_check_size_and_read_all() so 
I've applied this to my qemu-macppc branch.


ATB,

Mark.