This series includes some clean ups to mac_newworld and mac_oldworld
to make them a bit simpler and more readable, It also removes the
shared mac.h file that turns out was more of a random collection of
unrelated things. Getting rid of this mac.h improves the locality of
device models and reduces unnecessary interdependency.

v3: Some more patch spliting and changes I've noticed and address more
review comments
v2: Split some patches and add a few more I've noticed now and address
review comments

BALATON Zoltan (13):
  mac_newworld: Drop some variables
  mac_oldworld: Drop some more variables
  mac_{old|new}world: Set tbfreq at declaration
  mac_{old|new}world: Avoid else branch by setting default value
  mac_{old|new}world: Simplify cmdline_base calculation
  mac_newworld: Clean up creation of Uninorth devices
  mac_{old|new}world: Reduce number of QOM casts
  hw/ppc/mac.h: Move newworld specific parts out from shared header
  hw/ppc/mac.h: Move macio specific parts out from shared header
  hw/ppc/mac.h: Move grackle-pcihost type declaration out to a header
  hw/ppc/mac.h: Move PROM and KERNEL defines to board code
  hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h
  mac_nvram: Use NVRAM_SIZE constant

 MAINTAINERS                   |   2 +
 hw/ide/macio.c                |   1 -
 hw/intc/heathrow_pic.c        |   1 -
 hw/intc/openpic.c             |   1 -
 hw/misc/macio/cuda.c          |   1 -
 hw/misc/macio/gpio.c          |   1 -
 hw/misc/macio/macio.c         |   8 +-
 hw/misc/macio/pmu.c           |   1 -
 hw/nvram/mac_nvram.c          |   2 +-
 hw/pci-host/grackle.c         |  15 +--
 hw/pci-host/uninorth.c        |   1 -
 hw/ppc/mac.h                  | 105 ----------------
 hw/ppc/mac_newworld.c         | 225 ++++++++++++++++------------------
 hw/ppc/mac_oldworld.c         | 111 +++++++----------
 include/hw/misc/macio/macio.h |  23 +++-
 include/hw/nvram/mac_nvram.h  |  51 ++++++++
 include/hw/pci-host/grackle.h |  44 +++++++
 17 files changed, 280 insertions(+), 313 deletions(-)
 delete mode 100644 hw/ppc/mac.h
 create mode 100644 include/hw/nvram/mac_nvram.h
 create mode 100644 include/hw/pci-host/grackle.h

-- 
2.30.4

On Mon, 3 Oct 2022, BALATON Zoltan wrote:
> This series includes some clean ups to mac_newworld and mac_oldworld
> to make them a bit simpler and more readable, It also removes the
> shared mac.h file that turns out was more of a random collection of
> unrelated things. Getting rid of this mac.h improves the locality of
> device models and reduces unnecessary interdependency.

Ping?

> v3: Some more patch spliting and changes I've noticed and address more
> review comments
> v2: Split some patches and add a few more I've noticed now and address
> review comments
>
> BALATON Zoltan (13):
>  mac_newworld: Drop some variables
>  mac_oldworld: Drop some more variables
>  mac_{old|new}world: Set tbfreq at declaration
>  mac_{old|new}world: Avoid else branch by setting default value
>  mac_{old|new}world: Simplify cmdline_base calculation
>  mac_newworld: Clean up creation of Uninorth devices
>  mac_{old|new}world: Reduce number of QOM casts
>  hw/ppc/mac.h: Move newworld specific parts out from shared header
>  hw/ppc/mac.h: Move macio specific parts out from shared header
>  hw/ppc/mac.h: Move grackle-pcihost type declaration out to a header
>  hw/ppc/mac.h: Move PROM and KERNEL defines to board code
>  hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h
>  mac_nvram: Use NVRAM_SIZE constant
>
> MAINTAINERS                   |   2 +
> hw/ide/macio.c                |   1 -
> hw/intc/heathrow_pic.c        |   1 -
> hw/intc/openpic.c             |   1 -
> hw/misc/macio/cuda.c          |   1 -
> hw/misc/macio/gpio.c          |   1 -
> hw/misc/macio/macio.c         |   8 +-
> hw/misc/macio/pmu.c           |   1 -
> hw/nvram/mac_nvram.c          |   2 +-
> hw/pci-host/grackle.c         |  15 +--
> hw/pci-host/uninorth.c        |   1 -
> hw/ppc/mac.h                  | 105 ----------------
> hw/ppc/mac_newworld.c         | 225 ++++++++++++++++------------------
> hw/ppc/mac_oldworld.c         | 111 +++++++----------
> include/hw/misc/macio/macio.h |  23 +++-
> include/hw/nvram/mac_nvram.h  |  51 ++++++++
> include/hw/pci-host/grackle.h |  44 +++++++
> 17 files changed, 280 insertions(+), 313 deletions(-)
> delete mode 100644 hw/ppc/mac.h
> create mode 100644 include/hw/nvram/mac_nvram.h
> create mode 100644 include/hw/pci-host/grackle.h
>
>

On Tue, 11 Oct 2022, BALATON Zoltan wrote:
> On Mon, 3 Oct 2022, BALATON Zoltan wrote:
>> This series includes some clean ups to mac_newworld and mac_oldworld
>> to make them a bit simpler and more readable, It also removes the
>> shared mac.h file that turns out was more of a random collection of
>> unrelated things. Getting rid of this mac.h improves the locality of
>> device models and reduces unnecessary interdependency.
>
> Ping?

Ping^2 Only patch 4-5 still need a review. This series is a quite simple 
clean up with no functional change and it's on the list for a month now 
with this v3 is waiting for the last two weeks. I hoped to do some more 
changes after this was merged but with this rate of maintainer activity 
I'm not sure even this simple clean up can make it until the freeze and 
there seems to be no hope to get in more changes this year, We need to do 
something about this situation as it hinders development. It should not be 
so difficult to make even simple changes.

Regards,
BALATON Zoltan

>> v3: Some more patch spliting and changes I've noticed and address more
>> review comments
>> v2: Split some patches and add a few more I've noticed now and address
>> review comments
>> 
>> BALATON Zoltan (13):
>>  mac_newworld: Drop some variables
>>  mac_oldworld: Drop some more variables
>>  mac_{old|new}world: Set tbfreq at declaration
>>  mac_{old|new}world: Avoid else branch by setting default value
>>  mac_{old|new}world: Simplify cmdline_base calculation
>>  mac_newworld: Clean up creation of Uninorth devices
>>  mac_{old|new}world: Reduce number of QOM casts
>>  hw/ppc/mac.h: Move newworld specific parts out from shared header
>>  hw/ppc/mac.h: Move macio specific parts out from shared header
>>  hw/ppc/mac.h: Move grackle-pcihost type declaration out to a header
>>  hw/ppc/mac.h: Move PROM and KERNEL defines to board code
>>  hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h
>>  mac_nvram: Use NVRAM_SIZE constant
>> 
>> MAINTAINERS                   |   2 +
>> hw/ide/macio.c                |   1 -
>> hw/intc/heathrow_pic.c        |   1 -
>> hw/intc/openpic.c             |   1 -
>> hw/misc/macio/cuda.c          |   1 -
>> hw/misc/macio/gpio.c          |   1 -
>> hw/misc/macio/macio.c         |   8 +-
>> hw/misc/macio/pmu.c           |   1 -
>> hw/nvram/mac_nvram.c          |   2 +-
>> hw/pci-host/grackle.c         |  15 +--
>> hw/pci-host/uninorth.c        |   1 -
>> hw/ppc/mac.h                  | 105 ----------------
>> hw/ppc/mac_newworld.c         | 225 ++++++++++++++++------------------
>> hw/ppc/mac_oldworld.c         | 111 +++++++----------
>> include/hw/misc/macio/macio.h |  23 +++-
>> include/hw/nvram/mac_nvram.h  |  51 ++++++++
>> include/hw/pci-host/grackle.h |  44 +++++++
>> 17 files changed, 280 insertions(+), 313 deletions(-)
>> delete mode 100644 hw/ppc/mac.h
>> create mode 100644 include/hw/nvram/mac_nvram.h
>> create mode 100644 include/hw/pci-host/grackle.h
>> 
>> 
>
>

On 18/10/2022 12:37, BALATON Zoltan wrote:

> On Tue, 11 Oct 2022, BALATON Zoltan wrote:
>> On Mon, 3 Oct 2022, BALATON Zoltan wrote:
>>> This series includes some clean ups to mac_newworld and mac_oldworld
>>> to make them a bit simpler and more readable, It also removes the
>>> shared mac.h file that turns out was more of a random collection of
>>> unrelated things. Getting rid of this mac.h improves the locality of
>>> device models and reduces unnecessary interdependency.
>>
>> Ping?
> 
> Ping^2 Only patch 4-5 still need a review. This series is a quite simple clean up 
> with no functional change and it's on the list for a month now with this v3 is 
> waiting for the last two weeks. I hoped to do some more changes after this was merged 
> but with this rate of maintainer activity I'm not sure even this simple clean up can 
> make it until the freeze and there seems to be no hope to get in more changes this 
> year, We need to do something about this situation as it hinders development. It 
> should not be so difficult to make even simple changes.

I've had a look at patch 4 in the v3 series and that seems okay to me (I think I may 
have simply missed adding a R-B tag?), so if you can resend a v4 with patch 5 removed 
then I will send a PR for before freeze.

I appreciate that the rate of patch review can be frustrating, but this is something 
that is true for all QEMU developers. Remember there is no commercial sponsorship for 
the Mac PPC machines so the speed of review and testing is often limited by work 
deadlines and/or personal circumstances.


ATB,

Mark.