[v1] Misc ppc/mac machines clean up

[PATCH 00/10] Misc ppc/mac machines clean up

BALATON Zoltan posted 10 patches 3 years, 4 months ago

Diff against v2 v3 v4 v6 v7
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1663368422.git.balaton@eik.bme.hu

Maintainers: John Snow <jsnow@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

There is a newer version of this series

MAINTAINERS                   |   1 +
hw/ide/macio.c                |   1 -
hw/intc/heathrow_pic.c        |   1 -
hw/intc/openpic.c             |   1 -
hw/misc/macio/cuda.c          |   1 -
hw/misc/macio/gpio.c          |   1 -
hw/misc/macio/macio.c         |  27 ++++-
hw/misc/macio/pmu.c           |   1 -
hw/nvram/mac_nvram.c          |   2 +-
hw/pci-host/grackle.c         |   2 +-
hw/pci-host/uninorth.c        |   1 -
hw/ppc/mac.h                  | 105 ----------------
hw/ppc/mac_newworld.c         | 220 ++++++++++++++++------------------
hw/ppc/mac_oldworld.c         | 105 +++++++---------
include/hw/misc/macio/macio.h |   2 +-
include/hw/nvram/mac_nvram.h  |  49 ++++++++
16 files changed, 222 insertions(+), 298 deletions(-)
delete mode 100644 hw/ppc/mac.h
create mode 100644 include/hw/nvram/mac_nvram.h

Expand all Fold all

[PATCH 00/10] Misc ppc/mac machines clean up

Posted by BALATON Zoltan 3 years, 4 months ago

This series includes some clean ups to mac_newworld and mac_oldworld
to make them a bit simpler and more readable, It also removes the
shared mac.h file that turns out was more of a random collection of
unrelated things. Getting rid of this mac.h improves the locality of
device models and reduces unnecessary interdependency.

BALATON Zoltan (10):
  mac_newworld: Drop some variables
  mac_oldworld: Drop some more variables
  mac_{old|new}world: Set default values for some local variables
  mac_newworld: Simplify creation of Uninorth devices
  mac_{old|new}world: Reduce number of QOM casts
  hw/ppc/mac.h: Move newworld specific atuff out from shared header
  hw/ppc/mac.h: Move macio specific atuff out from shared header
  hw/ppc/mac.h: Move grackle-pcihost declaration out from shared header
  hw/ppc/mac.h: Move PROM and KERNEL defines to board code
  hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h

 MAINTAINERS                   |   1 +
 hw/ide/macio.c                |   1 -
 hw/intc/heathrow_pic.c        |   1 -
 hw/intc/openpic.c             |   1 -
 hw/misc/macio/cuda.c          |   1 -
 hw/misc/macio/gpio.c          |   1 -
 hw/misc/macio/macio.c         |  27 ++++-
 hw/misc/macio/pmu.c           |   1 -
 hw/nvram/mac_nvram.c          |   2 +-
 hw/pci-host/grackle.c         |   2 +-
 hw/pci-host/uninorth.c        |   1 -
 hw/ppc/mac.h                  | 105 ----------------
 hw/ppc/mac_newworld.c         | 220 ++++++++++++++++------------------
 hw/ppc/mac_oldworld.c         | 105 +++++++---------
 include/hw/misc/macio/macio.h |   2 +-
 include/hw/nvram/mac_nvram.h  |  49 ++++++++
 16 files changed, 222 insertions(+), 298 deletions(-)
 delete mode 100644 hw/ppc/mac.h
 create mode 100644 include/hw/nvram/mac_nvram.h

-- 
2.30.4

Re: [PATCH 00/10] Misc ppc/mac machines clean up

Posted by BALATON Zoltan 3 years, 4 months ago

On Sat, 17 Sep 2022, BALATON Zoltan wrote:
> This series includes some clean ups to mac_newworld and mac_oldworld
> to make them a bit simpler and more readable, It also removes the
> shared mac.h file that turns out was more of a random collection of
> unrelated things. Getting rid of this mac.h improves the locality of
> device models and reduces unnecessary interdependency.

Ping? Patches still needing review: 3, 4, 6, 8, 10

Regards,
BALATON Zoltan

> BALATON Zoltan (10):
>  mac_newworld: Drop some variables
>  mac_oldworld: Drop some more variables
>  mac_{old|new}world: Set default values for some local variables
>  mac_newworld: Simplify creation of Uninorth devices
>  mac_{old|new}world: Reduce number of QOM casts
>  hw/ppc/mac.h: Move newworld specific atuff out from shared header
>  hw/ppc/mac.h: Move macio specific atuff out from shared header
>  hw/ppc/mac.h: Move grackle-pcihost declaration out from shared header
>  hw/ppc/mac.h: Move PROM and KERNEL defines to board code
>  hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h
>
> MAINTAINERS                   |   1 +
> hw/ide/macio.c                |   1 -
> hw/intc/heathrow_pic.c        |   1 -
> hw/intc/openpic.c             |   1 -
> hw/misc/macio/cuda.c          |   1 -
> hw/misc/macio/gpio.c          |   1 -
> hw/misc/macio/macio.c         |  27 ++++-
> hw/misc/macio/pmu.c           |   1 -
> hw/nvram/mac_nvram.c          |   2 +-
> hw/pci-host/grackle.c         |   2 +-
> hw/pci-host/uninorth.c        |   1 -
> hw/ppc/mac.h                  | 105 ----------------
> hw/ppc/mac_newworld.c         | 220 ++++++++++++++++------------------
> hw/ppc/mac_oldworld.c         | 105 +++++++---------
> include/hw/misc/macio/macio.h |   2 +-
> include/hw/nvram/mac_nvram.h  |  49 ++++++++
> 16 files changed, 222 insertions(+), 298 deletions(-)
> delete mode 100644 hw/ppc/mac.h
> create mode 100644 include/hw/nvram/mac_nvram.h
>
>

Re: [PATCH 00/10] Misc ppc/mac machines clean up

Posted by Mark Cave-Ayland 3 years, 4 months ago

On 24/09/2022 14:09, BALATON Zoltan wrote:

> On Sat, 17 Sep 2022, BALATON Zoltan wrote:
>> This series includes some clean ups to mac_newworld and mac_oldworld
>> to make them a bit simpler and more readable, It also removes the
>> shared mac.h file that turns out was more of a random collection of
>> unrelated things. Getting rid of this mac.h improves the locality of
>> device models and reduces unnecessary interdependency.
> 
> Ping? Patches still needing review: 3, 4, 6, 8, 10
> 
> Regards,
> BALATON Zoltan

I've tagged this series for review, and plan to have a look over it either later 
today or tomorrow.


ATB,

Mark.