[v1] QOMify PPC4xx devices and minor clean ups

[PATCH 20/22] hw/ppc/Kconfig: Move imply before select

Posted by BALATON Zoltan 3 years, 5 months ago

In pegasos2 section move imply before select to match other sections.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/ppc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index 205f9f98d7..3a4418a69e 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -71,6 +71,7 @@ config SAM460EX
 
 config PEGASOS2
     bool
+    imply ATI_VGA
     select MV64361
     select VT82C686
     select IDE_VIA
@@ -78,7 +79,6 @@ config PEGASOS2
     select VOF
 # This should come with VT82C686
     select ACPI_X86
-    imply ATI_VGA
 
 config PREP
     bool
-- 
2.30.4

Re: [PATCH 20/22] hw/ppc/Kconfig: Move imply before select

Posted by Cédric Le Goater 3 years, 5 months ago

On 8/13/22 17:34, BALATON Zoltan wrote:
> In pegasos2 section move imply before select to match other sections.

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/ppc/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index 205f9f98d7..3a4418a69e 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -71,6 +71,7 @@ config SAM460EX
>   
>   config PEGASOS2
>       bool
> +    imply ATI_VGA
>       select MV64361
>       select VT82C686
>       select IDE_VIA
> @@ -78,7 +79,6 @@ config PEGASOS2
>       select VOF
>   # This should come with VT82C686
>       select ACPI_X86
> -    imply ATI_VGA
>   
>   config PREP
>       bool