On Samstag, 30. April 2022 18:37:40 CEST Richard Henderson wrote:
> On 4/30/22 04:44, Christian Schoenebeck wrote:
> > The following changes since commit
731340813fdb4cb8339edb8630e3f923b7d987ec:
> > Merge tag 'pull-riscv-to-apply-20220429' of github.com:alistair23/qemu
> > into staging (2022-04-29 08:46:55 -0700)>
> > are available in the Git repository at:
> > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20220430
> >
> > for you to fetch changes up to e8fb9ed725fe2ed00a275674a84beb5ba6e538a7:
> > 9pfs: fix qemu_mknodat() to always return -1 on error on macOS host
> > (2022-04-30 13:11:48 +0200)>
> > ----------------------------------------------------------------
> > 9pfs: various fixes
> >
> > * macOS: Fix recently (in QEMU 7.0) added 9p support for macOS hosts.
> >
> > * Tests: Fix inode sequencing in 'synth' driver.
> >
> > ----------------------------------------------------------------
> >
> > Christian Schoenebeck (7):
> > 9pfs: fix inode sequencing in 'synth' driver
> > 9pfs: fix qemu_mknodat(S_IFREG) on macOS
> > 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS
> > 9pfs: fix wrong encoding of rdev field in Rgetattr on macOS
> > 9pfs: fix wrong errno being sent to Linux client on macOS host
> > 9pfs: fix removing non-existent POSIX ACL xattr on macOS host
> > 9pfs: fix qemu_mknodat() to always return -1 on error on macOS host
> >
> > hw/9pfs/9p-posix-acl.c | 12 +++++++--
> > hw/9pfs/9p-synth.c | 4 +--
> > hw/9pfs/9p-util-darwin.c | 54 +++++++++++++++++++++++++++++++++++--
> > hw/9pfs/9p-util.h | 69
> > ++++++++++++++++++++++++++++++++++++++++++++++++ hw/9pfs/9p.c
> > | 4 ++-
> > 5 files changed, 136 insertions(+), 7 deletions(-)
>
> Fails with
>
> ../hw/9pfs/9p-util-darwin.c:107:46: error: use of undeclared identifier
> 'AT_SYMLINK_NOFOLLOW_ANY'
> err = fchmodat(AT_FDCWD, filename, mode, AT_SYMLINK_NOFOLLOW_ANY);
> ^
> 1 error generated.
>
> https://gitlab.com/qemu-project/qemu/-/jobs/2398467527
>
>
> r~
Nice. I just realized AT_SYMLINK_NOFOLLOW_ANY was added with Xcode 13.3, which
supposedly means >= macOS 12.3. And it wasn't marked by Apple as such. :/
I suggest I just s/AT_SYMLINK_NOFOLLOW_ANY/AT_SYMLINK_NOFOLLOW/ on my end and
post v2 PR, for consistency and as it does not really make a huge difference
IMO which one of the two is used in create_socket_file_at_cwd().
Any objections?
Best regards,
Christian Schoenebeck