[v2] More SH4 clean ups

[PATCH v2 01/11] hw/sh4: Fix a typo in a comment

Posted by BALATON Zoltan 4 years, 3 months ago

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 hw/timer/sh_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c
index 02eb865908..0a18ac8276 100644
--- a/hw/timer/sh_timer.c
+++ b/hw/timer/sh_timer.c
@@ -107,7 +107,7 @@ static void sh_timer_write(void *opaque, hwaddr offset,
         if (s->enabled) {
             /*
              * Pause the timer if it is running. This may cause some inaccuracy
-             * dure to rounding, but avoids a whole lot of other messyness
+             * due to rounding, but avoids a whole lot of other messyness
              */
             ptimer_stop(s->timer);
         }
-- 
2.21.4

Re: [PATCH v2 01/11] hw/sh4: Fix a typo in a comment

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

On 10/27/21 15:46, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  hw/timer/sh_timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c
> index 02eb865908..0a18ac8276 100644
> --- a/hw/timer/sh_timer.c
> +++ b/hw/timer/sh_timer.c
> @@ -107,7 +107,7 @@ static void sh_timer_write(void *opaque, hwaddr offset,
>          if (s->enabled) {
>              /*
>               * Pause the timer if it is running. This may cause some inaccuracy
> -             * dure to rounding, but avoids a whole lot of other messyness
> +             * due to rounding, but avoids a whole lot of other messyness

Also "messiness", otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>               */
>              ptimer_stop(s->timer);
>          }
>

Re: [PATCH v2 01/11] hw/sh4: Fix a typo in a comment

Posted by BALATON Zoltan 4 years, 3 months ago

On Wed, 27 Oct 2021, Philippe Mathieu-Daudé wrote:
> On 10/27/21 15:46, BALATON Zoltan wrote:
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>  hw/timer/sh_timer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c
>> index 02eb865908..0a18ac8276 100644
>> --- a/hw/timer/sh_timer.c
>> +++ b/hw/timer/sh_timer.c
>> @@ -107,7 +107,7 @@ static void sh_timer_write(void *opaque, hwaddr offset,
>>          if (s->enabled) {
>>              /*
>>               * Pause the timer if it is running. This may cause some inaccuracy
>> -             * dure to rounding, but avoids a whole lot of other messyness
>> +             * due to rounding, but avoids a whole lot of other messyness
>
> Also "messiness", otherwise:

I wasn't sure that's a word but appears in a dictionary so I'll change 
that too.

Regards,
BALATON Zoltan

> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
>>               */
>>              ptimer_stop(s->timer);
>>          }
>>
>
>