[PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

BALATON Zoltan posted 4 patches 2 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1635161629.git.balaton@eik.bme.hu
Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Gerd Hoffmann <kraxel@redhat.com>, Huacai Chen <chenhuacai@kernel.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>
There is a newer version of this series
hw/usb/hcd-uhci.c          | 14 ++++++++------
hw/usb/hcd-uhci.h          |  3 ++-
hw/usb/vt82c686-uhci-pci.c | 15 +++++++++++++++
3 files changed, 25 insertions(+), 7 deletions(-)
[PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Posted by BALATON Zoltan 2 years, 6 months ago
This is the same as posted before just omitting the two patches that
are optimisations by caching the func0 and avoiding QOM casts which
could not be measured to have an effect but these reamaining patches
are still needed to fix USB interrupts on pegasos2

Gerd, could you please take them?

Regards,

BALATON Zoltan (4):
  usb/uhci: Misc clean up
  usb/uhci: Disallow user creating a vt82c686-uhci-pci device
  usb/uhci: Replace pci_set_irq with qemu_set_irq
  hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

 hw/usb/hcd-uhci.c          | 14 ++++++++------
 hw/usb/hcd-uhci.h          |  3 ++-
 hw/usb/vt82c686-uhci-pci.c | 15 +++++++++++++++
 3 files changed, 25 insertions(+), 7 deletions(-)

-- 
2.21.4


Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Posted by Philippe Mathieu-Daudé 2 years, 6 months ago
On 10/25/21 13:33, BALATON Zoltan wrote:
> This is the same as posted before just omitting the two patches that
> are optimisations by caching the func0 and avoiding QOM casts which
> could not be measured to have an effect but these reamaining patches
> are still needed to fix USB interrupts on pegasos2
> 
> Gerd, could you please take them?
> 
> Regards,
> 
> BALATON Zoltan (4):
>   usb/uhci: Misc clean up
>   usb/uhci: Disallow user creating a vt82c686-uhci-pci device
>   usb/uhci: Replace pci_set_irq with qemu_set_irq
>   hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

Thanks, series applied to mips-next tree.

Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Posted by BALATON Zoltan 2 years, 6 months ago
Hello,

On Mon, 25 Oct 2021, Philippe Mathieu-Daudé wrote:
> On 10/25/21 13:33, BALATON Zoltan wrote:
>> This is the same as posted before just omitting the two patches that
>> are optimisations by caching the func0 and avoiding QOM casts which
>> could not be measured to have an effect but these reamaining patches
>> are still needed to fix USB interrupts on pegasos2
>>
>> Gerd, could you please take them?
>>
>> Regards,
>>
>> BALATON Zoltan (4):
>>   usb/uhci: Misc clean up
>>   usb/uhci: Disallow user creating a vt82c686-uhci-pci device
>>   usb/uhci: Replace pci_set_irq with qemu_set_irq
>>   hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
>
> Thanks, series applied to mips-next tree.

According to https://wiki.qemu.org/Planning/6.2 freeze starts today and I 
haven't yet seen a pull request with this series. Is it still to come? (As 
it is fixing a bug with USB IRQ it may be OK before hard freeze but to be 
safe I'm asking now to avoid missing a release and having to wait months 
to get it merged).

Thank you,
BALATON Zoltan
Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Posted by Philippe Mathieu-Daudé 2 years, 6 months ago
On 11/2/21 11:53, BALATON Zoltan wrote:
> Hello,
> 
> On Mon, 25 Oct 2021, Philippe Mathieu-Daudé wrote:
>> On 10/25/21 13:33, BALATON Zoltan wrote:
>>> This is the same as posted before just omitting the two patches that
>>> are optimisations by caching the func0 and avoiding QOM casts which
>>> could not be measured to have an effect but these reamaining patches
>>> are still needed to fix USB interrupts on pegasos2
>>>
>>> Gerd, could you please take them?
>>>
>>> Regards,
>>>
>>> BALATON Zoltan (4):
>>>   usb/uhci: Misc clean up
>>>   usb/uhci: Disallow user creating a vt82c686-uhci-pci device
>>>   usb/uhci: Replace pci_set_irq with qemu_set_irq
>>>   hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
>>
>> Thanks, series applied to mips-next tree.
> 
> According to https://wiki.qemu.org/Planning/6.2 freeze starts today and
> I haven't yet seen a pull request with this series. Is it still to come?
> (As it is fixing a bug with USB IRQ it may be OK before hard freeze but
> to be safe I'm asking now to avoid missing a release and having to wait
> months to get it merged).

According to my time zone it is only 1pm here, the day is not yet
finished :)

Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Posted by Gerd Hoffmann 2 years, 6 months ago
On Tue, Nov 02, 2021 at 11:53:18AM +0100, BALATON Zoltan wrote:
> Hello,
> 
> On Mon, 25 Oct 2021, Philippe Mathieu-Daudé wrote:
> > On 10/25/21 13:33, BALATON Zoltan wrote:
> > > This is the same as posted before just omitting the two patches that
> > > are optimisations by caching the func0 and avoiding QOM casts which
> > > could not be measured to have an effect but these reamaining patches
> > > are still needed to fix USB interrupts on pegasos2
> > > 
> > > Gerd, could you please take them?
> > > 
> > > Regards,
> > > 
> > > BALATON Zoltan (4):
> > >   usb/uhci: Misc clean up
> > >   usb/uhci: Disallow user creating a vt82c686-uhci-pci device
> > >   usb/uhci: Replace pci_set_irq with qemu_set_irq
> > >   hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
> > 
> > Thanks, series applied to mips-next tree.
> 
> According to https://wiki.qemu.org/Planning/6.2 freeze starts today and I
> haven't yet seen a pull request with this series. Is it still to come?

Oh, damn, was busy with edk2 stuff and didn't notice the freeze is
*that* close already.  Going over pending bits now and prepare a pull
req ...

take care,
  Gerd


Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Posted by BALATON Zoltan 2 years, 6 months ago
On Tue, 2 Nov 2021, Gerd Hoffmann wrote:
> On Tue, Nov 02, 2021 at 11:53:18AM +0100, BALATON Zoltan wrote:
>> Hello,
>>
>> On Mon, 25 Oct 2021, Philippe Mathieu-Daudé wrote:
>>> On 10/25/21 13:33, BALATON Zoltan wrote:
>>>> This is the same as posted before just omitting the two patches that
>>>> are optimisations by caching the func0 and avoiding QOM casts which
>>>> could not be measured to have an effect but these reamaining patches
>>>> are still needed to fix USB interrupts on pegasos2
>>>>
>>>> Gerd, could you please take them?
>>>>
>>>> Regards,
>>>>
>>>> BALATON Zoltan (4):
>>>>   usb/uhci: Misc clean up
>>>>   usb/uhci: Disallow user creating a vt82c686-uhci-pci device
>>>>   usb/uhci: Replace pci_set_irq with qemu_set_irq
>>>>   hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
>>>
>>> Thanks, series applied to mips-next tree.
>>
>> According to https://wiki.qemu.org/Planning/6.2 freeze starts today and I
>> haven't yet seen a pull request with this series. Is it still to come?
>
> Oh, damn, was busy with edk2 stuff and didn't notice the freeze is
> *that* close already.  Going over pending bits now and prepare a pull
> req ...

I think this series is taken care of by Philippe already so if you have 
other bits to go over that's fine, maybe you don't have to worry about 
this one. Was just asking to make sure this won't miss the release.

Regards,
BALATON Zoltan
Re: [PATCH v2 0/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Posted by Philippe Mathieu-Daudé 2 years, 6 months ago
On 11/2/21 13:42, BALATON Zoltan wrote:
> On Tue, 2 Nov 2021, Gerd Hoffmann wrote:
>> On Tue, Nov 02, 2021 at 11:53:18AM +0100, BALATON Zoltan wrote:
>>> Hello,
>>>
>>> On Mon, 25 Oct 2021, Philippe Mathieu-Daudé wrote:
>>>> On 10/25/21 13:33, BALATON Zoltan wrote:
>>>>> This is the same as posted before just omitting the two patches that
>>>>> are optimisations by caching the func0 and avoiding QOM casts which
>>>>> could not be measured to have an effect but these reamaining patches
>>>>> are still needed to fix USB interrupts on pegasos2
>>>>>
>>>>> Gerd, could you please take them?
>>>>>
>>>>> Regards,
>>>>>
>>>>> BALATON Zoltan (4):
>>>>>   usb/uhci: Misc clean up
>>>>>   usb/uhci: Disallow user creating a vt82c686-uhci-pci device
>>>>>   usb/uhci: Replace pci_set_irq with qemu_set_irq
>>>>>   hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
>>>>
>>>> Thanks, series applied to mips-next tree.
>>>
>>> According to https://wiki.qemu.org/Planning/6.2 freeze starts today
>>> and I
>>> haven't yet seen a pull request with this series. Is it still to come?
>>
>> Oh, damn, was busy with edk2 stuff and didn't notice the freeze is
>> *that* close already.  Going over pending bits now and prepare a pull
>> req ...
> 
> I think this series is taken care of by Philippe already so if you have
> other bits to go over that's fine, maybe you don't have to worry about
> this one. Was just asking to make sure this won't miss the release.

Yes, I just flushed the MIPS patch queue.