Fix defect in TranslationBlock insertion procedure

[PATCH 0/2] Fix defect in TranslationBlock insertion procedure

Liren Wei posted 2 patches 4 years, 7 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1625404483.git.lrwei@bupt.edu.cn

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>

accel/tcg/translate-all.c | 15 ++++++++-------
include/tcg/tcg.h         |  1 -
tcg/region.c              | 18 +++++++-----------
3 files changed, 15 insertions(+), 19 deletions(-)

Expand all Fold all

[PATCH 0/2] Fix defect in TranslationBlock insertion procedure

Posted by Liren Wei 4 years, 7 months ago

TranslationBlocks are now inserted first into QHT and then into its
corresponding tcg_region_tree. This is problematic under MTTCG, as
other vCPU threads may immediately execute it, and even bailout before
the TB itself is inserted into its tcg_region_tree, resulting in an
incorrect CPUState after rewinding.

Liren Wei (2):
  accel/tcg: Hoist tcg_tb_insert() up above tb_link_page()
  tcg: Bake tb_destroy() into tcg_region_tree

 accel/tcg/translate-all.c | 15 ++++++++-------
 include/tcg/tcg.h         |  1 -
 tcg/region.c              | 18 +++++++-----------
 3 files changed, 15 insertions(+), 19 deletions(-)

-- 
2.32.0