[PATCH v2 1/3] ppc4xx: Move common dependency on serial to common option

BALATON Zoltan via posted 3 patches 4 years, 10 months ago
Maintainers: BALATON Zoltan <balaton@eik.bme.hu>, Greg Kurz <groug@kaod.org>, David Gibson <david@gibson.dropbear.id.au>
[PATCH v2 1/3] ppc4xx: Move common dependency on serial to common option
Posted by BALATON Zoltan via 4 years, 10 months ago
All machines that select SERIAL also select PPC4XX so we can just add
this common dependency there once.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/ppc/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index dd86e664d2..8548f42b0d 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -37,7 +37,6 @@ config PPC405
     select M48T59
     select PFLASH_CFI02
     select PPC4XX
-    select SERIAL
 
 config PPC440
     bool
@@ -46,13 +45,13 @@ config PPC440
     imply E1000_PCI
     select PCI_EXPRESS
     select PPC4XX
-    select SERIAL
     select FDT_PPC
 
 config PPC4XX
     bool
     select BITBANG_I2C
     select PCI
+    select SERIAL
 
 config SAM460EX
     bool
@@ -61,7 +60,6 @@ config SAM460EX
     select IDE_SII3112
     select M41T80
     select PPC440
-    select SERIAL
     select SM501
     select SMBUS_EEPROM
     select USB_EHCI_SYSBUS
@@ -123,7 +121,6 @@ config VIRTEX
     bool
     select PPC4XX
     select PFLASH_CFI01
-    select SERIAL
     select XILINX
     select XILINX_ETHLITE
     select FDT_PPC
-- 
2.21.3


Re: [PATCH v2 1/3] ppc4xx: Move common dependency on serial to common option
Posted by David Gibson 4 years, 10 months ago
On Thu, Dec 31, 2020 at 12:11:55PM +0100, BALATON Zoltan via wrote:
> All machines that select SERIAL also select PPC4XX so we can just add
> this common dependency there once.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Applied to ppc-for-6.0.

> ---
>  hw/ppc/Kconfig | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index dd86e664d2..8548f42b0d 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -37,7 +37,6 @@ config PPC405
>      select M48T59
>      select PFLASH_CFI02
>      select PPC4XX
> -    select SERIAL
>  
>  config PPC440
>      bool
> @@ -46,13 +45,13 @@ config PPC440
>      imply E1000_PCI
>      select PCI_EXPRESS
>      select PPC4XX
> -    select SERIAL
>      select FDT_PPC
>  
>  config PPC4XX
>      bool
>      select BITBANG_I2C
>      select PCI
> +    select SERIAL
>  
>  config SAM460EX
>      bool
> @@ -61,7 +60,6 @@ config SAM460EX
>      select IDE_SII3112
>      select M41T80
>      select PPC440
> -    select SERIAL
>      select SM501
>      select SMBUS_EEPROM
>      select USB_EHCI_SYSBUS
> @@ -123,7 +121,6 @@ config VIRTEX
>      bool
>      select PPC4XX
>      select PFLASH_CFI01
> -    select SERIAL
>      select XILINX
>      select XILINX_ETHLITE
>      select FDT_PPC

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [PATCH v2 1/3] ppc4xx: Move common dependency on serial to common option
Posted by BALATON Zoltan via 4 years, 10 months ago
On Mon, 4 Jan 2021, David Gibson wrote:
> On Thu, Dec 31, 2020 at 12:11:55PM +0100, BALATON Zoltan via wrote:
>> All machines that select SERIAL also select PPC4XX so we can just add
>> this common dependency there once.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> Applied to ppc-for-6.0.

Not yet please, I'll send another version with changes suggested by 
Thomas. and also noticed another patch in this series needs update so I'll 
wait until tomorrow to see if anybody else has anything to say then will 
send and updated series.

Regards,
BALATON Zoltan.

>> ---
>>  hw/ppc/Kconfig | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
>> index dd86e664d2..8548f42b0d 100644
>> --- a/hw/ppc/Kconfig
>> +++ b/hw/ppc/Kconfig
>> @@ -37,7 +37,6 @@ config PPC405
>>      select M48T59
>>      select PFLASH_CFI02
>>      select PPC4XX
>> -    select SERIAL
>>
>>  config PPC440
>>      bool
>> @@ -46,13 +45,13 @@ config PPC440
>>      imply E1000_PCI
>>      select PCI_EXPRESS
>>      select PPC4XX
>> -    select SERIAL
>>      select FDT_PPC
>>
>>  config PPC4XX
>>      bool
>>      select BITBANG_I2C
>>      select PCI
>> +    select SERIAL
>>
>>  config SAM460EX
>>      bool
>> @@ -61,7 +60,6 @@ config SAM460EX
>>      select IDE_SII3112
>>      select M41T80
>>      select PPC440
>> -    select SERIAL
>>      select SM501
>>      select SMBUS_EEPROM
>>      select USB_EHCI_SYSBUS
>> @@ -123,7 +121,6 @@ config VIRTEX
>>      bool
>>      select PPC4XX
>>      select PFLASH_CFI01
>> -    select SERIAL
>>      select XILINX
>>      select XILINX_ETHLITE
>>      select FDT_PPC
>
>