[v3] 9pfs: add tests using local fs driver

[PATCH v3 06/11] tests/qtest/qos-test: dump QEMU command if verbose

Posted by Christian Schoenebeck 5 years, 4 months ago

If qtests are run in verbose mode (i.e. if --verbose CL argument
was provided) then print the assembled qemu command line for each
test.

Instead of using g_test_message() rather use printf() in combination
with g_test_verbose(), to avoid g_test_message() cluttering the
output.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
 tests/qtest/qos-test.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
index fe240b32a7..b9f0942386 100644
--- a/tests/qtest/qos-test.c
+++ b/tests/qtest/qos-test.c
@@ -89,6 +89,9 @@ static void qos_set_machines_devices_available(void)
 
 static void restart_qemu_or_continue(char *path)
 {
+    if (g_test_verbose()) {
+        printf("Run QEMU with: '%s'\n", path);
+    }
     /* compares the current command line with the
      * one previously executed: if they are the same,
      * don't restart QEMU, if they differ, stop previous
-- 
2.20.1

Re: [PATCH v3 06/11] tests/qtest/qos-test: dump QEMU command if verbose

Posted by Paolo Bonzini 5 years, 4 months ago

On 02/10/20 18:15, Christian Schoenebeck wrote:
> If qtests are run in verbose mode (i.e. if --verbose CL argument
> was provided) then print the assembled qemu command line for each
> test.
> 
> Instead of using g_test_message() rather use printf() in combination
> with g_test_verbose(), to avoid g_test_message() cluttering the
> output.
> 
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
>  tests/qtest/qos-test.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
> index fe240b32a7..b9f0942386 100644
> --- a/tests/qtest/qos-test.c
> +++ b/tests/qtest/qos-test.c
> @@ -89,6 +89,9 @@ static void qos_set_machines_devices_available(void)
>  
>  static void restart_qemu_or_continue(char *path)
>  {
> +    if (g_test_verbose()) {
> +        printf("Run QEMU with: '%s'\n", path);
> +    }
>      /* compares the current command line with the
>       * one previously executed: if they are the same,
>       * don't restart QEMU, if they differ, stop previous
> 

This need not even be made verbose I think.

Paolo

Re: [PATCH v3 06/11] tests/qtest/qos-test: dump QEMU command if verbose

Posted by Christian Schoenebeck 5 years, 4 months ago

On Donnerstag, 8. Oktober 2020 14:36:11 CEST Paolo Bonzini wrote:
> On 02/10/20 18:15, Christian Schoenebeck wrote:
> > If qtests are run in verbose mode (i.e. if --verbose CL argument
> > was provided) then print the assembled qemu command line for each
> > test.
> > 
> > Instead of using g_test_message() rather use printf() in combination
> > with g_test_verbose(), to avoid g_test_message() cluttering the
> > output.
> > 
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
> > 
> >  tests/qtest/qos-test.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
> > index fe240b32a7..b9f0942386 100644
> > --- a/tests/qtest/qos-test.c
> > +++ b/tests/qtest/qos-test.c
> > @@ -89,6 +89,9 @@ static void qos_set_machines_devices_available(void)
> > 
> >  static void restart_qemu_or_continue(char *path)
> >  {
> > 
> > +    if (g_test_verbose()) {
> > +        printf("Run QEMU with: '%s'\n", path);
> > +    }
> > 
> >      /* compares the current command line with the
> >      
> >       * one previously executed: if they are the same,
> >       * don't restart QEMU, if they differ, stop previous
> 
> This need not even be made verbose I think.

I actually find that handy in this way. By default I prefer the current output 
where I just see the name of the test currently running. I only need to see 
the actual QEMU command if there is some kind of problem to fix.

Best regards,
Christian Schoenebeck