Make preallocate_co() resize the image to the correct size

[PATCH 0/2] Make preallocate_co() resize the image to the correct size

Alberto Garcia posted 2 patches 3 years, 7 months ago

Download series mbox

Failed in applying to current master (apply log)

block/qcow2.h              |  6 +++---
block/qcow2-cluster.c      | 14 +++++++++----
block/qcow2.c              | 35 +++++++++++++--------------------
tests/qemu-iotests/125     | 40 +++++++++++++++++++++-----------------
tests/qemu-iotests/125.out | 28 ++++++++++++++++++++++++--
5 files changed, 74 insertions(+), 49 deletions(-)

Expand all Fold all

[PATCH 0/2] Make preallocate_co() resize the image to the correct size

Posted by Alberto Garcia 3 years, 7 months ago

preallocate_co() does not resize the image correctly if the original
size was not cluster-aligned.

This series should be applied on top of Max's block branch (I tested
it with commit 8e66c829eda997dad661d49d73668b1fd3e6043d).

   https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Alberto Garcia (2):
  qcow2: Make preallocate_co() resize the image to the correct size
  qcow2: Convert qcow2_alloc_cluster_offset() into
    qcow2_alloc_host_offset()

 block/qcow2.h              |  6 +++---
 block/qcow2-cluster.c      | 14 +++++++++----
 block/qcow2.c              | 35 +++++++++++++--------------------
 tests/qemu-iotests/125     | 40 +++++++++++++++++++++-----------------
 tests/qemu-iotests/125.out | 28 ++++++++++++++++++++++++--
 5 files changed, 74 insertions(+), 49 deletions(-)

-- 
2.20.1

Re: [PATCH 0/2] Make preallocate_co() resize the image to the correct size

Posted by Max Reitz 3 years, 7 months ago

On 11.09.20 16:09, Alberto Garcia wrote:
> preallocate_co() does not resize the image correctly if the original
> size was not cluster-aligned.
> 
> This series should be applied on top of Max's block branch (I tested
> it with commit 8e66c829eda997dad661d49d73668b1fd3e6043d).
> 
>    https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 
> Alberto Garcia (2):
>   qcow2: Make preallocate_co() resize the image to the correct size
>   qcow2: Convert qcow2_alloc_cluster_offset() into
>     qcow2_alloc_host_offset()
> 
>  block/qcow2.h              |  6 +++---
>  block/qcow2-cluster.c      | 14 +++++++++----
>  block/qcow2.c              | 35 +++++++++++++--------------------
>  tests/qemu-iotests/125     | 40 +++++++++++++++++++++-----------------
>  tests/qemu-iotests/125.out | 28 ++++++++++++++++++++++++--
>  5 files changed, 74 insertions(+), 49 deletions(-)

Thanks, applied to my block branch.

Max