[PATCH v2 0/8] fcntl, sockopt, and ioctl options

Shu-Chun Weng posted 8 patches 3 years, 8 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Failed in applying to current master (apply log)
include/exec/user/thunk.h              |  24 +
linux-user/Makefile.objs               |   3 +-
linux-user/alpha/sockbits.h            |  21 +-
linux-user/ethtool.c                   | 840 +++++++++++++++++++++++++
linux-user/ethtool.h                   |  20 +
linux-user/ethtool_entries.h           | 107 ++++
linux-user/generic/sockbits.h          |  17 +-
linux-user/hppa/sockbits.h             |  20 +-
linux-user/ioctls.h                    |   2 +
linux-user/mips/sockbits.h             |  16 +-
linux-user/qemu.h                      |   1 +
linux-user/sparc/sockbits.h            |  21 +-
linux-user/strace.c                    | 188 +++++-
linux-user/syscall.c                   | 286 ++++++++-
linux-user/syscall_defs.h              |  26 +-
linux-user/syscall_types.h             | 280 +++++++++
tests/tcg/multiarch/ethtool.c          | 423 +++++++++++++
tests/tcg/multiarch/socket_timestamp.c | 540 ++++++++++++++++
thunk.c                                | 152 ++++-
19 files changed, 2916 insertions(+), 71 deletions(-)
create mode 100644 linux-user/ethtool.c
create mode 100644 linux-user/ethtool.h
create mode 100644 linux-user/ethtool_entries.h
create mode 100644 tests/tcg/multiarch/ethtool.c
create mode 100644 tests/tcg/multiarch/socket_timestamp.c
[PATCH v2 0/8] fcntl, sockopt, and ioctl options
Posted by Shu-Chun Weng 3 years, 8 months ago
Hi Laurent,

This is a series of 8 patches in 4 groups, putting into a single thread for
easier tracking.

[PATCH v2 1/8] linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls
  An incidental follow up on
  https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01925.html

[PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option
[PATCH v2 3/8] linux-user: add missing IPv6 get/setsockopt option
[PATCH v2 4/8] linux-user: Add IPv6 options to do_print_sockopt()
  Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01317.html
  to consistently add them in get/setsockopt

[PATCH v2 5/8] linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW
[PATCH v2 6/8] linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPING
  Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01319.html
  to only use TARGET_SO_*_OLD/NEW

[PATCH v2 7/8] thunk: supports flexible arrays
[PATCH v2 8/8] linux-user: Add support for SIOCETHTOOL ioctl
  Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg05090.html

v1 -> v2:
  Address comments on the first 5 (was 3) patches.
  Fix style problems.

Shu-Chun Weng (8):
  linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls
  linux-user: add missing UDP get/setsockopt option
  linux-user: add missing IPv6 get/setsockopt option
  linux-user: Add IPv6 options to do_print_sockopt()
  linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW
  linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPING
  thunk: supports flexible arrays
  linux-user: Add support for SIOCETHTOOL ioctl

 include/exec/user/thunk.h              |  24 +
 linux-user/Makefile.objs               |   3 +-
 linux-user/alpha/sockbits.h            |  21 +-
 linux-user/ethtool.c                   | 840 +++++++++++++++++++++++++
 linux-user/ethtool.h                   |  20 +
 linux-user/ethtool_entries.h           | 107 ++++
 linux-user/generic/sockbits.h          |  17 +-
 linux-user/hppa/sockbits.h             |  20 +-
 linux-user/ioctls.h                    |   2 +
 linux-user/mips/sockbits.h             |  16 +-
 linux-user/qemu.h                      |   1 +
 linux-user/sparc/sockbits.h            |  21 +-
 linux-user/strace.c                    | 188 +++++-
 linux-user/syscall.c                   | 286 ++++++++-
 linux-user/syscall_defs.h              |  26 +-
 linux-user/syscall_types.h             | 280 +++++++++
 tests/tcg/multiarch/ethtool.c          | 423 +++++++++++++
 tests/tcg/multiarch/socket_timestamp.c | 540 ++++++++++++++++
 thunk.c                                | 152 ++++-
 19 files changed, 2916 insertions(+), 71 deletions(-)
 create mode 100644 linux-user/ethtool.c
 create mode 100644 linux-user/ethtool.h
 create mode 100644 linux-user/ethtool_entries.h
 create mode 100644 tests/tcg/multiarch/ethtool.c
 create mode 100644 tests/tcg/multiarch/socket_timestamp.c

-- 
2.28.0.220.ged08abb693-goog


Re: [PATCH v2 0/8] fcntl, sockopt, and ioctl options
Posted by Laurent Vivier 3 years, 4 months ago
Hi Shu-Chun,

I'm sorry for the delay.

Your series doesn't apply anymore.

Could you rebase it and send a new version. I'll merge the 4 first patches.

Thanks,
Laurent

Le 11/08/2020 à 09:09, Shu-Chun Weng a écrit :
> Hi Laurent,
> 
> This is a series of 8 patches in 4 groups, putting into a single thread for
> easier tracking.
> 
> [PATCH v2 1/8] linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls
>   An incidental follow up on
>   https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01925.html
> 
> [PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option
> [PATCH v2 3/8] linux-user: add missing IPv6 get/setsockopt option
> [PATCH v2 4/8] linux-user: Add IPv6 options to do_print_sockopt()
>   Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01317.html
>   to consistently add them in get/setsockopt
> 
> [PATCH v2 5/8] linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW
> [PATCH v2 6/8] linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPING
>   Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01319.html
>   to only use TARGET_SO_*_OLD/NEW
> 
> [PATCH v2 7/8] thunk: supports flexible arrays
> [PATCH v2 8/8] linux-user: Add support for SIOCETHTOOL ioctl
>   Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg05090.html
> 
> v1 -> v2:
>   Address comments on the first 5 (was 3) patches.
>   Fix style problems.
> 
> Shu-Chun Weng (8):
>   linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls
>   linux-user: add missing UDP get/setsockopt option
>   linux-user: add missing IPv6 get/setsockopt option
>   linux-user: Add IPv6 options to do_print_sockopt()
>   linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW
>   linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPING
>   thunk: supports flexible arrays
>   linux-user: Add support for SIOCETHTOOL ioctl
> 
>  include/exec/user/thunk.h              |  24 +
>  linux-user/Makefile.objs               |   3 +-
>  linux-user/alpha/sockbits.h            |  21 +-
>  linux-user/ethtool.c                   | 840 +++++++++++++++++++++++++
>  linux-user/ethtool.h                   |  20 +
>  linux-user/ethtool_entries.h           | 107 ++++
>  linux-user/generic/sockbits.h          |  17 +-
>  linux-user/hppa/sockbits.h             |  20 +-
>  linux-user/ioctls.h                    |   2 +
>  linux-user/mips/sockbits.h             |  16 +-
>  linux-user/qemu.h                      |   1 +
>  linux-user/sparc/sockbits.h            |  21 +-
>  linux-user/strace.c                    | 188 +++++-
>  linux-user/syscall.c                   | 286 ++++++++-
>  linux-user/syscall_defs.h              |  26 +-
>  linux-user/syscall_types.h             | 280 +++++++++
>  tests/tcg/multiarch/ethtool.c          | 423 +++++++++++++
>  tests/tcg/multiarch/socket_timestamp.c | 540 ++++++++++++++++
>  thunk.c                                | 152 ++++-
>  19 files changed, 2916 insertions(+), 71 deletions(-)
>  create mode 100644 linux-user/ethtool.c
>  create mode 100644 linux-user/ethtool.h
>  create mode 100644 linux-user/ethtool_entries.h
>  create mode 100644 tests/tcg/multiarch/ethtool.c
>  create mode 100644 tests/tcg/multiarch/socket_timestamp.c
>