[PATCH v5 6/7] io: Document thread-safety of qio_channel_shutdown

Lukas Straub posted 7 patches 5 years, 7 months ago
There is a newer version of this series
[PATCH v5 6/7] io: Document thread-safety of qio_channel_shutdown
Posted by Lukas Straub 5 years, 7 months ago
Migration and yank code assume that qio_channel_shutdown is thread
-safe. Document this after checking the code.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
 include/io/channel.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/io/channel.h b/include/io/channel.h
index d4557f0930..6b8a2b87b8 100644
--- a/include/io/channel.h
+++ b/include/io/channel.h
@@ -516,6 +516,8 @@ int qio_channel_close(QIOChannel *ioc,
  * QIO_CHANNEL_FEATURE_SHUTDOWN prior to calling
  * this method.
  *
+ * This function is thread-safe.
+ *
  * Returns: 0 on success, -1 on error
  */
 int qio_channel_shutdown(QIOChannel *ioc,
--
2.20.1

Re: [PATCH v5 6/7] io: Document thread-safety of qio_channel_shutdown
Posted by Daniel P. Berrangé 5 years, 6 months ago
On Tue, Jun 23, 2020 at 04:42:59PM +0200, Lukas Straub wrote:
> Migration and yank code assume that qio_channel_shutdown is thread
> -safe. Document this after checking the code.
> 
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> ---
>  include/io/channel.h | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|