[v5] Add subcluster allocation to qcow2

[PATCH v5 15/31] qcow2: Add qcow2_cluster_is_allocated()

Posted by Alberto Garcia 5 years, 6 months ago

This helper function tells us if a cluster is allocated (that is,
there is an associated host offset for it).

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 block/qcow2.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/block/qcow2.h b/block/qcow2.h
index be7816a3b8..b5db8d2f36 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -763,6 +763,12 @@ QCow2SubclusterType qcow2_get_subcluster_type(BlockDriverState *bs,
     }
 }
 
+static inline bool qcow2_cluster_is_allocated(QCow2ClusterType type)
+{
+    return (type == QCOW2_CLUSTER_COMPRESSED || type == QCOW2_CLUSTER_NORMAL ||
+            type == QCOW2_CLUSTER_ZERO_ALLOC);
+}
+
 /* Check whether refcounts are eager or lazy */
 static inline bool qcow2_need_accurate_refcounts(BDRVQcow2State *s)
 {
-- 
2.20.1

Re: [PATCH v5 15/31] qcow2: Add qcow2_cluster_is_allocated()

Posted by Eric Blake 5 years, 6 months ago

On 5/5/20 12:38 PM, Alberto Garcia wrote:
> This helper function tells us if a cluster is allocated (that is,
> there is an associated host offset for it).
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   block/qcow2.h | 6 ++++++
>   1 file changed, 6 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/qcow2.h b/block/qcow2.h
> index be7816a3b8..b5db8d2f36 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -763,6 +763,12 @@ QCow2SubclusterType qcow2_get_subcluster_type(BlockDriverState *bs,
>       }
>   }
>   
> +static inline bool qcow2_cluster_is_allocated(QCow2ClusterType type)
> +{
> +    return (type == QCOW2_CLUSTER_COMPRESSED || type == QCOW2_CLUSTER_NORMAL ||
> +            type == QCOW2_CLUSTER_ZERO_ALLOC);
> +}
> +
>   /* Check whether refcounts are eager or lazy */
>   static inline bool qcow2_need_accurate_refcounts(BDRVQcow2State *s)
>   {
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org