[v4] colo-compare bugfixes

[PATCH v4 0/6] colo-compare bugfixes

Lukas Straub posted 6 patches 4 years ago

Diff against v1 v1 v2 v3 v5 v6
Download series mbox

Test docker-mingw@fedora failed

Test asan failed

Test checkpatch passed

Test docker-quick@centos7 failed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1588587700.git.lukasstraub2@web.de

Maintainers: Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Zhang Chen <chen.zhang@intel.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Li Zhijian <lizhijian@cn.fujitsu.com>

There is a newer version of this series

chardev/char.c     |   7 +-
net/colo-compare.c | 250 +++++++++++++++++++++++++++++++++------------
net/colo-compare.h |   1 +
net/colo.c         |   7 ++
net/colo.h         |   1 +
softmmu/vl.c       |   2 +
6 files changed, 204 insertions(+), 64 deletions(-)

Expand all Fold all

[PATCH v4 0/6] colo-compare bugfixes

Posted by Lukas Straub 4 years ago

Hello Everyone,
Here are fixes for bugs that I found in my tests.

Benchmark results:
Client-to-server tcp:
without patch: ~63 Mbit/s
with patch: ~66 Mbit/s
Server-to-client tcp:
without patch: ~771 Kbit/s
with patch: ~702 Kbit/s

Regards,
Lukas Straub

Version changes:
v4:
 -fix potential deadlock with notify_remote_frame
 -avoid malloc and memcpy in many cases

v3:
 -fix checkpatch.pl error

v2:
 -better wording
 -fix performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in compare_chr_send"
 -add more bugfixes


Lukas Straub (6):
  net/colo-compare.c: Create event_bh with the right AioContext
  chardev/char.c: Use qemu_co_sleep_ns if in coroutine
  net/colo-compare.c: Fix deadlock in compare_chr_send
  net/colo-compare.c: Only hexdump packets if tracing is enabled
  net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active
  net/colo-compare.c: Correct ordering in complete and finalize

 chardev/char.c     |   7 +-
 net/colo-compare.c | 250 +++++++++++++++++++++++++++++++++------------
 net/colo-compare.h |   1 +
 net/colo.c         |   7 ++
 net/colo.h         |   1 +
 softmmu/vl.c       |   2 +
 6 files changed, 204 insertions(+), 64 deletions(-)

-- 
2.20.1

RE: [PATCH v4 0/6] colo-compare bugfixes

Posted by Zhang, Chen 3 years, 11 months ago

Please update this series, I will queue it to COLO branch.

Thanks
Zhang Chen

> -----Original Message-----
> From: Lukas Straub <lukasstraub2@web.de>
> Sent: Monday, May 4, 2020 6:28 PM
> To: qemu-devel <qemu-devel@nongnu.org>
> Cc: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian
> <lizhijian@cn.fujitsu.com>; Jason Wang <jasowang@redhat.com>; Marc-
> André Lureau <marcandre.lureau@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>
> Subject: [PATCH v4 0/6] colo-compare bugfixes
> 
> Hello Everyone,
> Here are fixes for bugs that I found in my tests.
> 
> Benchmark results:
> Client-to-server tcp:
> without patch: ~63 Mbit/s
> with patch: ~66 Mbit/s
> Server-to-client tcp:
> without patch: ~771 Kbit/s
> with patch: ~702 Kbit/s
> 
> Regards,
> Lukas Straub
> 
> Version changes:
> v4:
>  -fix potential deadlock with notify_remote_frame  -avoid malloc and
> memcpy in many cases
> 
> v3:
>  -fix checkpatch.pl error
> 
> v2:
>  -better wording
>  -fix performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in
> compare_chr_send"
>  -add more bugfixes
> 
> 
> Lukas Straub (6):
>   net/colo-compare.c: Create event_bh with the right AioContext
>   chardev/char.c: Use qemu_co_sleep_ns if in coroutine
>   net/colo-compare.c: Fix deadlock in compare_chr_send
>   net/colo-compare.c: Only hexdump packets if tracing is enabled
>   net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active
>   net/colo-compare.c: Correct ordering in complete and finalize
> 
>  chardev/char.c     |   7 +-
>  net/colo-compare.c | 250 +++++++++++++++++++++++++++++++++---------
> ---
>  net/colo-compare.h |   1 +
>  net/colo.c         |   7 ++
>  net/colo.h         |   1 +
>  softmmu/vl.c       |   2 +
>  6 files changed, 204 insertions(+), 64 deletions(-)
> 
> --
> 2.20.1