[PATCH v2 0/3] Improved reporting for migrate parameters

Mao Zhongyi posted 3 patches 4 years ago
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test FreeBSD passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1585641083.git.maozhongyi@cmss.chinamobile.com
Maintainers: Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
migration/migration.c | 20 ++++++++++++--------
monitor/hmp-cmds.c    | 13 ++++++++-----
2 files changed, 20 insertions(+), 13 deletions(-)
[PATCH v2 0/3] Improved reporting for migrate parameters
Posted by Mao Zhongyi 4 years ago
This series mainly improve the report message of migrate parameters
to make it easier to read.

v2->v1
-p1: avoid using constants, replace it with stringify().

Cc: quintela@redhat.com
Cc: dgilbert@redhat.com

Mao Zhongyi (3):
  migration/migration: improve error reporting for migrate parameters
  monitor/hmp-cmds: add hmp_handle_error() for hmp_migrate_set_speed()
  migration: move the units of migrate parameters from milliseconds to
    ms

 migration/migration.c | 20 ++++++++++++--------
 monitor/hmp-cmds.c    | 13 ++++++++-----
 2 files changed, 20 insertions(+), 13 deletions(-)

-- 
2.17.1




Re: [PATCH v2 0/3] Improved reporting for migrate parameters
Posted by no-reply@patchew.org 4 years ago
Patchew URL: https://patchew.org/QEMU/cover.1585641083.git.maozhongyi@cmss.chinamobile.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
  QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
  QEMU=/usr/libexec/qemu-kvm
else
  exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/cover.1585641083.git.maozhongyi@cmss.chinamobile.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 0/3] Improved reporting for migrate parameters
Posted by no-reply@patchew.org 4 years ago
Patchew URL: https://patchew.org/QEMU/cover.1585641083.git.maozhongyi@cmss.chinamobile.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/cover.1585641083.git.maozhongyi@cmss.chinamobile.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 0/3] Improved reporting for migrate parameters
Posted by no-reply@patchew.org 4 years ago
Patchew URL: https://patchew.org/QEMU/cover.1585641083.git.maozhongyi@cmss.chinamobile.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 0/3] Improved reporting for migrate parameters
Message-id: cover.1585641083.git.maozhongyi@cmss.chinamobile.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

fatal: unable to access 'https://github.com/patchew-project/qemu/': Failed connect to github.com:443; Connection timed out
Traceback (most recent call last):
  File "patchew-tester2/src/patchew-cli", line 531, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester2/src/patchew-cli", line 57, in git_clone_repo
    cwd=cache_repo, stdout=logf, stderr=logf)
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'fetch', '3c8cf5a9c21ff8782164d1def7f44bd888713384', '+refs/tags/patchew/cover.1585641083.git.maozhongyi@cmss.chinamobile.com:refs/tags/patchew/cover.1585641083.git.maozhongyi@cmss.chinamobile.com']' returned non-zero exit status 128.



The full log is available at
http://patchew.org/logs/cover.1585641083.git.maozhongyi@cmss.chinamobile.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 0/3] Improved reporting for migrate parameters
Posted by Dr. David Alan Gilbert 3 years, 11 months ago
* Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote:
> This series mainly improve the report message of migrate parameters
> to make it easier to read.

Queued

> v2->v1
> -p1: avoid using constants, replace it with stringify().
> 
> Cc: quintela@redhat.com
> Cc: dgilbert@redhat.com
> 
> Mao Zhongyi (3):
>   migration/migration: improve error reporting for migrate parameters
>   monitor/hmp-cmds: add hmp_handle_error() for hmp_migrate_set_speed()
>   migration: move the units of migrate parameters from milliseconds to
>     ms
> 
>  migration/migration.c | 20 ++++++++++++--------
>  monitor/hmp-cmds.c    | 13 ++++++++-----
>  2 files changed, 20 insertions(+), 13 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK