block/qcow2: Fix bitmap reopen with 'auto-read-only' file child

[PATCH 0/2] block/qcow2: Fix bitmap reopen with 'auto-read-only' file child

Peter Krempa posted 2 patches 5 years, 8 months ago

Download series mbox

Test docker-quick@centos7 failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1582893284.git.pkrempa@redhat.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block.c                   | 9 +++++++++
block/qcow2.c             | 7 ++++++-
include/block/block_int.h | 1 +
3 files changed, 16 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH 0/2] block/qcow2: Fix bitmap reopen with 'auto-read-only' file child

Posted by Peter Krempa 5 years, 8 months ago

See patch 2/2 for explanation. Also please excuse the lack of tests
caused by my ignorance of not figuring out where to put them.

Peter Krempa (2):
  block: Introduce 'bdrv_reopen_commit_post' step
  block/qcow2: Move bitmap reopen into bdrv_reopen_commit_post

 block.c                   | 9 +++++++++
 block/qcow2.c             | 7 ++++++-
 include/block/block_int.h | 1 +
 3 files changed, 16 insertions(+), 1 deletion(-)

-- 
2.24.1

Re: [PATCH 0/2] block/qcow2: Fix bitmap reopen with 'auto-read-only' file child

Posted by Kevin Wolf 5 years, 8 months ago

Am 28.02.2020 um 13:44 hat Peter Krempa geschrieben:
> See patch 2/2 for explanation. Also please excuse the lack of tests
> caused by my ignorance of not figuring out where to put them.

Thanks, applied to the block branch.

A test would probably live in test/qemu-iotests/. Test case 245 is
specifically about x-blockdev-reopen, so we could consider putting it
there, or you could just create a new test case.

Kevin