[Qemu-devel] [PATCH 0/3] Audio: misc fixes for "Audio 20190821 patches", part two

Kővágó, Zoltán posted 3 patches 4 years, 7 months ago
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1568157545.git.DirtY.iCE.hu@gmail.com
audio/audio_template.h | 7 +++++--
audio/paaudio.c        | 9 ++++++---
qapi/audio.json        | 6 ++++++
3 files changed, 17 insertions(+), 5 deletions(-)
[Qemu-devel] [PATCH 0/3] Audio: misc fixes for "Audio 20190821 patches", part two
Posted by Kővágó, Zoltán 4 years, 7 months ago
Hi,

This series contains some random fixes for the "Audio 20190821 patches":
a coverity bugfix and pulseaudio connection/stream names fix.

Since there wasn't a clear consensus about naming the pa streams, I've
split it into two commits: the first time just uses the audiodev id
unconditionally, while the last commit adds a new option to qapi to
override it.  This way we can easily drop the last commit if it turns
out to be unnecessary.

Regards,
Zoltan


Kővágó, Zoltán (3):
  audio: fix parameter dereference before NULL check
  audio: paaudio: fix connection and stream name
  audio: paaudio: ability to specify stream name

 audio/audio_template.h | 7 +++++--
 audio/paaudio.c        | 9 ++++++---
 qapi/audio.json        | 6 ++++++
 3 files changed, 17 insertions(+), 5 deletions(-)

-- 
2.23.0


Re: [Qemu-devel] [PATCH 0/3] Audio: misc fixes for "Audio 20190821 patches", part two
Posted by Peter Maydell 4 years, 6 months ago
Hi -- not sure what's happened with this patchset, but
can we at least get the first patch (which fixes some
coverity errors) in, even if the other two need more
consideration?

(cc'ing Gerd as audio maintainer.)

thanks
-- PMM


On Wed, 11 Sep 2019 at 00:27, Kővágó, Zoltán <dirty.ice.hu@gmail.com> wrote:
>
> Hi,
>
> This series contains some random fixes for the "Audio 20190821 patches":
> a coverity bugfix and pulseaudio connection/stream names fix.
>
> Since there wasn't a clear consensus about naming the pa streams, I've
> split it into two commits: the first time just uses the audiodev id
> unconditionally, while the last commit adds a new option to qapi to
> override it.  This way we can easily drop the last commit if it turns
> out to be unnecessary.
>
> Regards,
> Zoltan
>
>
> Kővágó, Zoltán (3):
>   audio: fix parameter dereference before NULL check
>   audio: paaudio: fix connection and stream name
>   audio: paaudio: ability to specify stream name
>
>  audio/audio_template.h | 7 +++++--
>  audio/paaudio.c        | 9 ++++++---
>  qapi/audio.json        | 6 ++++++
>  3 files changed, 17 insertions(+), 5 deletions(-)