[Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication

Lukas Straub posted 4 patches 4 years, 7 months ago
Test docker-clang@ubuntu passed
Test FreeBSD passed
Test checkpatch failed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1567500411.git.lukasstraub2@web.de
Maintainers: Xie Changlong <xiechanglong.d@gmail.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Max Reitz <mreitz@redhat.com>, Wen Congyang <wencongyang2@huawei.com>, Kevin Wolf <kwolf@redhat.com>, Jason Wang <jasowang@redhat.com>
There is a newer version of this series
block/replication.c        |  38 ++++++-
docs/COLO-FT.txt           | 212 +++++++++++++++++++++++++++----------
docs/block-replication.txt |  26 +++--
include/net/filter.h       |   2 +
net/filter.c               |  78 +++++++++++++-
qemu-options.hx            |  10 +-
tests/test-replication.c   |  52 +++++++++
7 files changed, 343 insertions(+), 75 deletions(-)
[Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication
Posted by Lukas Straub 4 years, 7 months ago
Hello Everyone,
These Patches add support for continious replication to colo. This means
that after the Primary fails and the Secondary did a failover, the Secondary
can then become Primary and resume replication to a new Secondary.

On a side note, I wrote a Pacemaker Resource Agent for colo which I will
post when its ready.
I have to say it's quite fun to randomly kill a Node, wait for resync
and repeat and see how the VM stays alive all the time. :)

Regards,
Lukas Straub

v3:
 - add test for replication changes
 - check if the filter to be inserted before/behind belongs to the same interface
 - fix the error message for the position= parameter
 - rename term "after" -> "behind" and variable "insert_before" -> "insert_before_flag"
 - document the quorum node on the secondary side
 - simplify quorum parameters in documentation
 - remove trailing spaces in documentation
 - clarify the testing procedure in documentation

v2:
 - fix email formating
 - fix checkpatch.pl warnings
 - fix patchew error
 - clearer commit messages

Lukas Straub (4):
  block/replication.c: Ignore requests after failover
  tests/test-replication.c: Add test for ignoring requests after
    failover
  net/filter.c: Add Options to insert filters anywhere in the filter
    list
  colo: Update Documentation for continious replication

 block/replication.c        |  38 ++++++-
 docs/COLO-FT.txt           | 212 +++++++++++++++++++++++++++----------
 docs/block-replication.txt |  26 +++--
 include/net/filter.h       |   2 +
 net/filter.c               |  78 +++++++++++++-
 qemu-options.hx            |  10 +-
 tests/test-replication.c   |  52 +++++++++
 7 files changed, 343 insertions(+), 75 deletions(-)

--
2.20.1

Re: [Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication
Posted by no-reply@patchew.org 4 years, 7 months ago
Patchew URL: https://patchew.org/QEMU/cover.1567500411.git.lukasstraub2@web.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication
Type: series
Message-id: cover.1567500411.git.lukasstraub2@web.de

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0a1cf27 colo: Update Documentation for continious replication
c789287 net/filter.c: Add Options to insert filters anywhere in the filter list
81d0607 tests/test-replication.c: Add test for ignoring requests after failover
a177f86 block/replication.c: Ignore requests after failover

=== OUTPUT BEGIN ===
1/4 Checking commit a177f86211a7 (block/replication.c: Ignore requests after failover)
2/4 Checking commit 81d060732781 (tests/test-replication.c: Add test for ignoring requests after failover)
ERROR: space prohibited after that open parenthesis '('
#41: FILE: tests/test-replication.c:514:
+    replication_stop_all( true, &local_err);

ERROR: space prohibited after that open parenthesis '('
#55: FILE: tests/test-replication.c:528:
+    replication_stop_all( true, &local_err);

total: 2 errors, 0 warnings, 64 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/4 Checking commit c78928785a9f (net/filter.c: Add Options to insert filters anywhere in the filter list)
4/4 Checking commit 0a1cf27070de (colo: Update Documentation for continious replication)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1567500411.git.lukasstraub2@web.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com