[v1] colo: Add support for continious replication

[Qemu-devel] [PATCH 0/3] colo: Add support for continious replication

Lukas Straub posted 3 patches 4 years, 8 months ago

Diff against v2 v2 v3 v4
Download series mbox

Test FreeBSD passed

Test docker-mingw@fedora passed

Test asan passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test s390x failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1565814686.git.lukasstraub2@web.de

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Xie Changlong <xiechanglong.d@gmail.com>, Wen Congyang <wencongyang2@huawei.com>, Jason Wang <jasowang@redhat.com>

There is a newer version of this series

block/replication.c  |  31 +++++++-
docs/COLO-FT.txt     | 185 ++++++++++++++++++++++++++++++++-----------
include/net/filter.h |   2 +
net/filter.c         |  73 ++++++++++++++++-
qemu-options.hx      |  10 +--
5 files changed, 243 insertions(+), 58 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] colo: Add support for continious replication

Posted by Lukas Straub 4 years, 8 months ago

Hello Everyone,
These Patches add support for continious replication to colo.
Please review.

Regards,
Lukas Straub

Lukas Straub (3):
  Replication: Ignore requests after failover
  net/filter.c: Add Options to insert filters anywhere in the filter list
  Document the qmp commands for continious replication

 block/replication.c  |  31 +++++++-
 docs/COLO-FT.txt     | 185 ++++++++++++++++++++++++++++++++-----------
 include/net/filter.h |   2 +
 net/filter.c         |  73 ++++++++++++++++-
 qemu-options.hx      |  10 +--
 5 files changed, 243 insertions(+), 58 deletions(-)

--
2.20.1

Re: [Qemu-devel] [PATCH 0/3] colo: Add support for continious replication

Posted by no-reply@patchew.org 4 years, 8 months ago

Patchew URL: https://patchew.org/QEMU/cover.1565814686.git.lukasstraub2@web.de/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa

echo
echo "=== UNAME ==="
uname -a

CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

                 from /var/tmp/patchew-tester-tmp-6ji6qfi2/src/include/net/filter.h:13,
                 from /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:14:
/var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c: In function ‘netfilter_complete’:
/var/tmp/patchew-tester-tmp-6ji6qfi2/src/include/qemu/queue.h:412:44: error: ‘position’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  412 |         (listelm)->field.tqe_circ.tql_prev = &(elm)->field.tqe_circ;         \
      |                                            ^
/var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:237:21: note: ‘position’ was declared here


The full log is available at
http://patchew.org/logs/cover.1565814686.git.lukasstraub2@web.de/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/3] colo: Add support for continious replication

Posted by Zhang, Chen 4 years, 8 months ago

Hi Lukas,

Please fix this issue and add more comments in the commit log.

Thanks
Zhang Chen

> -----Original Message-----
> From: no-reply@patchew.org [mailto:no-reply@patchew.org]
> Sent: Thursday, August 15, 2019 11:20 AM
> To: lukasstraub2@web.de
> Cc: Zhang, Chen <chen.zhang@intel.com>; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH 0/3] colo: Add support for continious
> replication
> 
> Patchew URL:
> https://patchew.org/QEMU/cover.1565814686.git.lukasstraub2@web.de/
> 
> 
> 
> Hi,
> 
> This series failed build test on s390x host. Please find the details below.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> # Testing script will be invoked under the git checkout with # HEAD pointing to
> a commit that has the patches applied on top of "base"
> # branch
> set -e
> 
> echo
> echo "=== ENV ==="
> env
> 
> echo
> echo "=== PACKAGES ==="
> rpm -qa
> 
> echo
> echo "=== UNAME ==="
> uname -a
> 
> CC=$HOME/bin/cc
> INSTALL=$PWD/install
> BUILD=$PWD/build
> mkdir -p $BUILD $INSTALL
> SRC=$PWD
> cd $BUILD
> $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable
> clean up # make check -j4 V=1 make install === TEST SCRIPT END ===
> 
>                  from /var/tmp/patchew-tester-tmp-
> 6ji6qfi2/src/include/net/filter.h:13,
>                  from /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:14:
> /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c: In function
> ‘netfilter_complete’:
> /var/tmp/patchew-tester-tmp-6ji6qfi2/src/include/qemu/queue.h:412:44: error:
> ‘position’ may be used uninitialized in this function [-Werror=maybe-
> uninitialized]
>   412 |         (listelm)->field.tqe_circ.tql_prev = &(elm)->field.tqe_circ;         \
>       |                                            ^
> /var/tmp/patchew-tester-tmp-6ji6qfi2/src/net/filter.c:237:21: note: ‘position’
> was declared here
> 
> 
> The full log is available at
> http://patchew.org/logs/cover.1565814686.git.lukasstraub2@web.de/testing.s3
> 90x/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com