fix incorrect assertions in sd and main-loop

[Qemu-devel] [Qemu-devel PATCH v3 0/2] fix incorrect assertions in sd and main-loop

Lidong Chen posted 2 patches 6 years, 4 months ago

Download series mbox

Test s390x passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1560806687.git.lidong.chen@oracle.com

Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Paolo Bonzini <pbonzini@redhat.com>

hw/sd/sd.c       | 4 ++--
util/main-loop.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [Qemu-devel PATCH v3 0/2] fix incorrect assertions in sd and main-loop

Posted by Lidong Chen 6 years, 4 months ago

This v3 added Philippe's Reviewed-by in patch2 (main-loop.c) 
I also included Philippe's previous comment about patch1 (sd.c)
in this cover: 

--------
Not sure via which tree this patch is going (trivial?).
To the maintainer, please consider adding when applying:

"This access can not happen. Fix to silent static analyzer warnings."

As confirmed by Lidong in v1 here:
https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01337.html

Thanks,

Phil.
-------

Lidong Chen (2):
  sd: Fix out-of-bounds assertions
  util/main-loop: Fix incorrect assertion

 hw/sd/sd.c       | 4 ++--
 util/main-loop.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
1.8.3.1

Re: [Qemu-devel] [Qemu-devel PATCH v3 0/2] fix incorrect assertions in sd and main-loop

Posted by Philippe Mathieu-Daudé 6 years, 4 months ago

On 6/19/19 9:14 PM, Lidong Chen wrote:
> This v3 added Philippe's Reviewed-by in patch2 (main-loop.c) 

Thanks.

> I also included Philippe's previous comment about patch1 (sd.c)
> in this cover: 
> 
> --------
> Not sure via which tree this patch is going (trivial?).
> To the maintainer, please consider adding when applying:
> 
> "This access can not happen. Fix to silent static analyzer warnings."

What I asked you is to add this in the patch1 description.
If you were not to respin, then I'd ask the maintainer who takes this
series to amend this comment to the patch.

> 
> As confirmed by Lidong in v1 here:
> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01337.html
> 
> Thanks,
> 
> Phil.
> -------
> 
> Lidong Chen (2):
>   sd: Fix out-of-bounds assertions
>   util/main-loop: Fix incorrect assertion
> 
>  hw/sd/sd.c       | 4 ++--
>  util/main-loop.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>

Re: [Qemu-devel] [Qemu-devel PATCH v3 0/2] fix incorrect assertions in sd and main-loop

Posted by Paolo Bonzini 6 years, 4 months ago

On 19/06/19 21:14, Lidong Chen wrote:
> This v3 added Philippe's Reviewed-by in patch2 (main-loop.c) 
> I also included Philippe's previous comment about patch1 (sd.c)
> in this cover: 
> 
> --------
> Not sure via which tree this patch is going (trivial?).
> To the maintainer, please consider adding when applying:
> 
> "This access can not happen. Fix to silent static analyzer warnings."
> 
> As confirmed by Lidong in v1 here:
> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01337.html
> 
> Thanks,
> 
> Phil.
> -------
> 
> Lidong Chen (2):
>   sd: Fix out-of-bounds assertions
>   util/main-loop: Fix incorrect assertion
> 
>  hw/sd/sd.c       | 4 ++--
>  util/main-loop.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> -- 1.8.3.1

Queued, thanks.

Paolo