[v3] block: Use bdrv_unref_child() for all children in bdrv_close()

[Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close()

Alberto Garcia posted 2 patches 4 years, 11 months ago

Diff against v1 v2
Download series mbox

Test asan passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1557754872.git.berto@igalia.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>, Max Reitz <mreitz@redhat.com>, Alberto Garcia <berto@igalia.com>

block.c                     | 41 ++++++++++++++++++++---------------------
block/block-backend.c       |  3 +--
block/quorum.c              |  1 -
blockjob.c                  |  2 +-
tests/test-bdrv-drain.c     |  6 ------
tests/test-bdrv-graph-mod.c |  1 -
6 files changed, 22 insertions(+), 32 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close()

Posted by Alberto Garcia 4 years, 11 months ago

Hi,

the first patch is the same as in v2 (with an updated commit
message). The second patch is new and makes bdrv_root_attach_child()
unref child_bs on failure, as suggested by Max.

Regards,

Berto

v2: https://lists.gnu.org/archive/html/qemu-block/2019-05/msg00325.html
v1: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg01040.html

Alberto Garcia (2):
  block: Use bdrv_unref_child() for all children in bdrv_close()
  block: Make bdrv_root_attach_child() unref child_bs on failure

 block.c                     | 41 ++++++++++++++++++++---------------------
 block/block-backend.c       |  3 +--
 block/quorum.c              |  1 -
 blockjob.c                  |  2 +-
 tests/test-bdrv-drain.c     |  6 ------
 tests/test-bdrv-graph-mod.c |  1 -
 6 files changed, 22 insertions(+), 32 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close()

Posted by Max Reitz 4 years, 11 months ago

On 13.05.19 15:46, Alberto Garcia wrote:
> Hi,
> 
> the first patch is the same as in v2 (with an updated commit
> message). The second patch is new and makes bdrv_root_attach_child()
> unref child_bs on failure, as suggested by Max.
> 
> Regards,
> 
> Berto
> 
> v2: https://lists.gnu.org/archive/html/qemu-block/2019-05/msg00325.html
> v1: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg01040.html
> 
> Alberto Garcia (2):
>   block: Use bdrv_unref_child() for all children in bdrv_close()
>   block: Make bdrv_root_attach_child() unref child_bs on failure
> 
>  block.c                     | 41 ++++++++++++++++++++---------------------
>  block/block-backend.c       |  3 +--
>  block/quorum.c              |  1 -
>  blockjob.c                  |  2 +-
>  tests/test-bdrv-drain.c     |  6 ------
>  tests/test-bdrv-graph-mod.c |  1 -
>  6 files changed, 22 insertions(+), 32 deletions(-)

Thanks for bearing with me, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max