[v1] Remove bdrv_read() and bdrv_write()

[Qemu-devel] [PATCH 0/5] Remove bdrv_read() and bdrv_write()

Alberto Garcia posted 5 patches 6 years, 6 months ago

Diff against v2
Download series mbox

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test checkpatch passed

Test asan failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1556562150.git.berto@igalia.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>, Stefan Weil <sw@weilnetz.de>

There is a newer version of this series

block/io.c             | 36 ------------------------------------
block/qcow2-refcount.c |  4 ++--
block/qcow2.c          |  1 -
block/qcow2.h          |  1 -
block/vdi.c            | 11 ++++++-----
block/vvfat.c          | 10 ++++++----
include/block/block.h  |  4 ----
7 files changed, 14 insertions(+), 53 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/5] Remove bdrv_read() and bdrv_write()

Posted by Alberto Garcia 6 years, 6 months ago

Hi,

this API only had a few users left so it can be easily removed.

Regards,

Berto

Alberto Garcia (5):
  qcow2: Replace bdrv_write() with bdrv_pwrite()
  vdi: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()
  vvfat: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()
  block: Remove bdrv_read() and bdrv_write()
  qcow2: Remove BDRVQcow2State.cluster_sectors

 block/io.c             | 36 ------------------------------------
 block/qcow2-refcount.c |  4 ++--
 block/qcow2.c          |  1 -
 block/qcow2.h          |  1 -
 block/vdi.c            | 11 ++++++-----
 block/vvfat.c          | 10 ++++++----
 include/block/block.h  |  4 ----
 7 files changed, 14 insertions(+), 53 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH 0/5] Remove bdrv_read() and bdrv_write()

Posted by Eric Blake 6 years, 6 months ago

On 4/29/19 1:42 PM, Alberto Garcia wrote:
> Hi,
> 
> this API only had a few users left so it can be easily removed.

Sounds very similar to my earlier attempt at the same:

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg02769.html

> 
> Regards,
> 
> Berto
> 
> Alberto Garcia (5):
>   qcow2: Replace bdrv_write() with bdrv_pwrite()
>   vdi: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()
>   vvfat: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()
>   block: Remove bdrv_read() and bdrv_write()
>   qcow2: Remove BDRVQcow2State.cluster_sectors
> 
>  block/io.c             | 36 ------------------------------------
>  block/qcow2-refcount.c |  4 ++--
>  block/qcow2.c          |  1 -
>  block/qcow2.h          |  1 -
>  block/vdi.c            | 11 ++++++-----
>  block/vvfat.c          | 10 ++++++----
>  include/block/block.h  |  4 ----
>  7 files changed, 14 insertions(+), 53 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 0/5] Remove bdrv_read() and bdrv_write()

Posted by no-reply@patchew.org 6 years, 6 months ago

Patchew URL: https://patchew.org/QEMU/cover.1556562150.git.berto@igalia.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/cover.1556562150.git.berto@igalia.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/5] Remove bdrv_read() and bdrv_write()

Posted by no-reply@patchew.org 6 years, 6 months ago

Patchew URL: https://patchew.org/QEMU/cover.1556562150.git.berto@igalia.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/cover.1556562150.git.berto@igalia.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com