hw/mips/mips_fulong2e.c | 40 +++++++++++++++++----------------------- hw/pci-host/bonito.c | 7 ++++++- 2 files changed, 23 insertions(+), 24 deletions(-)
v2 of http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg02477.html Addressed review comments and removed last patch (sending it separately) to make this series not depend on my ati-vga patch so it can be applied independently. BALATON Zoltan (3): hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address mips_fulong2e: Fix bios flash size mips_fulong2e: Dynamically generate SPD EEPROM data hw/mips/mips_fulong2e.c | 40 +++++++++++++++++----------------------- hw/pci-host/bonito.c | 7 ++++++- 2 files changed, 23 insertions(+), 24 deletions(-) -- 2.13.7
On 2/18/19 1:01 PM, BALATON Zoltan wrote: > v2 of > http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg02477.html > Addressed review comments and removed last patch (sending it > separately) to make this series not depend on my ati-vga patch so it > can be applied independently. > > BALATON Zoltan (3): > hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address > mips_fulong2e: Fix bios flash size > mips_fulong2e: Dynamically generate SPD EEPROM data > > hw/mips/mips_fulong2e.c | 40 +++++++++++++++++----------------------- > hw/pci-host/bonito.c | 7 ++++++- > 2 files changed, 23 insertions(+), 24 deletions(-) For whoever who takes this series, please replace my mojibaked lastname with: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Thanks, Phil.
> From: BALATON Zoltan <balaton@eik.bme.hu> > v2 of http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg02477.html > Addressed review comments and removed last patch (sending it > separately) to make this series not depend on my ati-vga patch so it > can be applied independently. I plan to add bin file (that you mentioned) used for Fulong 2E tests into our tree (in pc-bios directory, with an appropriate comment in pc-bios/README). Please let me know if you this I should not do that, of if I should perhaps include more files, or different files, etc. Regards, Aleksandar
On Mon, 4 Mar 2019, Aleksandar Markovic wrote: >> From: BALATON Zoltan <balaton@eik.bme.hu> >> v2 of http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg02477.html >> Addressed review comments and removed last patch (sending it >> separately) to make this series not depend on my ati-vga patch so it >> can be applied independently. > > I plan to add bin file (that you mentioned) used for Fulong 2E tests into our > tree (in pc-bios directory, with an appropriate comment in pc-bios/README). > Please let me know if you this I should not do that, of if I should perhaps include > more files, or different files, etc. I think you cannot do that because distributing binary also requires to provide sources to comply with GPL. Therefore you should include source in roms and build binary from that like done for sam460ex for example (see: git log roms/u-boot-sam460ex). Problem is you have to figure out which sources and config was used to build that binary with the original lemote.com site mentioned in a comment in mips_fulong2e.c that used to host the source seemingly gone. So you probably will need to find a mirror and figure out how to build the pmon binary from that. The comment in source mentions that pmon is under BSD licence in which case it may be distributed without source but including random binaries may not be the best way even if it would be allowed by licence so building a firmware from source is the best way if possible. Regards, BALATON Zoltan
> From: BALATON Zoltan <balaton@eik.bme.hu> > Subject: Re: [PATCH v2 0/3] Misc MIPS fulong2e improvements > > On Mon, 4 Mar 2019, Aleksandar Markovic wrote: > >> From: BALATON Zoltan <balaton@eik.bme.hu> > >> v2 of http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg02477.html > >> Addressed review comments and removed last patch (sending it > >> separately) to make this series not depend on my ati-vga patch so it > >> can be applied independently. > > > > I plan to add bin file (that you mentioned) used for Fulong 2E tests into our > > tree (in pc-bios directory, with an appropriate comment in pc-bios/README). > > Please let me know if you this I should not do that, of if I should perhaps > include > > more files, or different files, etc. > > I think you cannot do that because distributing binary also requires to > provide sources to comply with GPL. Therefore you should include source in > roms and build binary from that like done for sam460ex for example (see: > git log roms/u-boot-sam460ex). Problem is you have to figure out which > sources and config was used to build that binary with the original > lemote.com site mentioned in a comment in mips_fulong2e.c that used to > host the source seemingly gone. So you probably will need to find a mirror > and figure out how to build the pmon binary from that. The comment in > source mentions that pmon is under BSD licence in which case it may be > distributed without source but including random binaries may not be the > best way even if it would be allowed by licence so building a firmware > from source is the best way if possible. OK, I will for now give up integrating the binary until all is clarified. Thanks! Aleksandar ________________________________________ From: BALATON Zoltan <balaton@eik.bme.hu> Sent: Monday, March 4, 2019 3:27:27 PM To: Aleksandar Markovic Cc: qemu-devel@nongnu.org; Aurelien Jarno; Huacai Chen; philmd@redhat.com Subject: Re: [PATCH v2 0/3] Misc MIPS fulong2e improvements On Mon, 4 Mar 2019, Aleksandar Markovic wrote: >> From: BALATON Zoltan <balaton@eik.bme.hu> >> v2 of http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg02477.html >> Addressed review comments and removed last patch (sending it >> separately) to make this series not depend on my ati-vga patch so it >> can be applied independently. > > I plan to add bin file (that you mentioned) used for Fulong 2E tests into our > tree (in pc-bios directory, with an appropriate comment in pc-bios/README). > Please let me know if you this I should not do that, of if I should perhaps include > more files, or different files, etc. I think you cannot do that because distributing binary also requires to provide sources to comply with GPL. Therefore you should include source in roms and build binary from that like done for sam460ex for example (see: git log roms/u-boot-sam460ex). Problem is you have to figure out which sources and config was used to build that binary with the original lemote.com site mentioned in a comment in mips_fulong2e.c that used to host the source seemingly gone. So you probably will need to find a mirror and figure out how to build the pmon binary from that. The comment in source mentions that pmon is under BSD licence in which case it may be distributed without source but including random binaries may not be the best way even if it would be allowed by licence so building a firmware from source is the best way if possible. Regards, BALATON Zoltan
© 2016 - 2024 Red Hat, Inc.