[Qemu-devel] [PATCH 0/9] target/mips: Limited support for R5900 multimedia instructions

Fredrik Noring posted 9 patches 5 years, 3 months ago
Test asan passed
Test checkpatch failed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1547403692.git.noring@nocrew.org
Maintainers: Aleksandar Markovic <amarkovic@wavecomp.com>, Stefan Markovic <smarkovic@wavecomp.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>
target/mips/cpu.h                     |   2 +
target/mips/translate.c               | 180 +++++++++++++++++++++++---
tests/tcg/mips/mipsn32r5900/Makefile  |  27 ++++
tests/tcg/mips/mipsn32r5900/lq.c      | 111 ++++++++++++++++
tests/tcg/mips/mipsn32r5900/pcpyuld.c |  46 +++++++
tests/tcg/mips/mipsn32r5900/sq.c      | 105 +++++++++++++++
6 files changed, 452 insertions(+), 19 deletions(-)
create mode 100644 tests/tcg/mips/mipsn32r5900/Makefile
create mode 100644 tests/tcg/mips/mipsn32r5900/lq.c
create mode 100644 tests/tcg/mips/mipsn32r5900/pcpyuld.c
create mode 100644 tests/tcg/mips/mipsn32r5900/sq.c
[Qemu-devel] [PATCH 0/9] target/mips: Limited support for R5900 multimedia instructions
Posted by Fredrik Noring 5 years, 3 months ago
This series introduces limited support for R5900 multimedia instructions
(MMIs) by implementing and testing PCPYLD, PCPYUD, LQ and SQ.

32 128-bit multimedia registers (MMRs) are introduced. They are split into
two 64-bit halves: the lower halves are the GPRs and the upper halves are
accessible by the R5900-specific multimedia instructions.

The MMIs are only available with TARGET_MIPS64 since 64-bit GPRs are
required.

The relation between SQ and RDHWR may need to be revisited. I'm hoping to
discuss the details with Maciej.

This series has been successfully built with the 10 different build
configurations

    {gcc,clang} x -m64 x mips{,64}el-{linux-user,softmmu}
    {gcc,clang} x -m64 x mipsn32el-linux-user

in addition successfully completing the R5900 test suite

    cd tests/tcg/mips/mipsr5900 && make check
    cd tests/tcg/mips/mipsn32r5900 && make check

Fredrik Noring (9):
  target/mips: Require TARGET_MIPS64 for R5900 multimedia instructions
  target/mips: Introduce 32 R5900 128-bit multimedia registers
  target/mips: Support the R5900 PCPYLD multimedia instruction
  target/mips: Support the R5900 PCPYUD multimedia instruction
  target/mips: Support the R5900 LQ multimedia instruction
  target/mips: Support the R5900 SQ multimedia instruction
  tests/tcg/mips: Test R5900 multimedia instructions PCPYUD and PCPYLD
  tests/tcg/mips: Test R5900 multimedia instruction LQ
  tests/tcg/mips: Test R5900 multimedia instruction SQ

 target/mips/cpu.h                     |   2 +
 target/mips/translate.c               | 180 +++++++++++++++++++++++---
 tests/tcg/mips/mipsn32r5900/Makefile  |  27 ++++
 tests/tcg/mips/mipsn32r5900/lq.c      | 111 ++++++++++++++++
 tests/tcg/mips/mipsn32r5900/pcpyuld.c |  46 +++++++
 tests/tcg/mips/mipsn32r5900/sq.c      | 105 +++++++++++++++
 6 files changed, 452 insertions(+), 19 deletions(-)
 create mode 100644 tests/tcg/mips/mipsn32r5900/Makefile
 create mode 100644 tests/tcg/mips/mipsn32r5900/lq.c
 create mode 100644 tests/tcg/mips/mipsn32r5900/pcpyuld.c
 create mode 100644 tests/tcg/mips/mipsn32r5900/sq.c

-- 
2.19.2


Re: [Qemu-devel] [PATCH 0/9] target/mips: Limited support for R5900 multimedia instructions
Posted by no-reply@patchew.org 5 years, 3 months ago
Patchew URL: https://patchew.org/QEMU/cover.1547403692.git.noring@nocrew.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: cover.1547403692.git.noring@nocrew.org
Subject: [Qemu-devel] [PATCH 0/9] target/mips: Limited support for R5900 multimedia instructions
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
de6a446 tests/tcg/mips: Test R5900 multimedia instruction SQ
0088bfa tests/tcg/mips: Test R5900 multimedia instruction LQ
6ff0c3e tests/tcg/mips: Test R5900 multimedia instructions PCPYUD and PCPYLD
9339214 target/mips: Support the R5900 SQ multimedia instruction
fa1b66f target/mips: Support the R5900 LQ multimedia instruction
4d02b79 target/mips: Support the R5900 PCPYUD multimedia instruction
5f97931 target/mips: Support the R5900 PCPYLD multimedia instruction
7788cd9 target/mips: Introduce 32 R5900 128-bit multimedia registers
bfb6880 target/mips: Require TARGET_MIPS64 for R5900 multimedia instructions

=== OUTPUT BEGIN ===
1/9 Checking commit bfb6880b6968 (target/mips: Require TARGET_MIPS64 for R5900 multimedia instructions)
2/9 Checking commit 7788cd938432 (target/mips: Introduce 32 R5900 128-bit multimedia registers)
3/9 Checking commit 5f97931d64fa (target/mips: Support the R5900 PCPYLD multimedia instruction)
4/9 Checking commit 4d02b79ee4cc (target/mips: Support the R5900 PCPYUD multimedia instruction)
5/9 Checking commit fa1b66faf41f (target/mips: Support the R5900 LQ multimedia instruction)
6/9 Checking commit 933921419413 (target/mips: Support the R5900 SQ multimedia instruction)
7/9 Checking commit 6ff0c3e10ea7 (tests/tcg/mips: Test R5900 multimedia instructions PCPYUD and PCPYLD)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 71 lines checked

Patch 7/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/9 Checking commit 0088bfa895fb (tests/tcg/mips: Test R5900 multimedia instruction LQ)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

ERROR: "(foo*)" should be "(foo *)"
#77: FILE: tests/tcg/mips/mipsn32r5900/lq.c:48:
+    const void *a = (const void*)((unsigned long)o & ~0xFUL);

ERROR: spaces required around that '=' (ctx:VxE)
#96: FILE: tests/tcg/mips/mipsn32r5900/lq.c:67:
+    static const char data[] __attribute__((aligned(16)))=
                                                          ^

total: 2 errors, 1 warnings, 120 lines checked

Patch 8/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/9 Checking commit de6a44645c76 (tests/tcg/mips: Test R5900 multimedia instruction SQ)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: "(foo*)" should be "(foo *)"
#61: FILE: tests/tcg/mips/mipsn32r5900/sq.c:34:
+    const uint8_t *a = (const uint8_t*)((unsigned long)o & ~0xFUL);

total: 1 errors, 1 warnings, 112 lines checked

Patch 9/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1547403692.git.noring@nocrew.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com