This patch series introduces the ability for virtual audio drivers to pass
information about guest-chosen DB values to backend audio drivers.

For now, supported virtual driver is hda-codec, and backend is pulseaudio, as
they both support DB values.

Without these patches, emulated Windows has a very short range of hearable
sound, as range in the guest is much smaller than in Pulseaudio.

Yaroslav Isakov (3):
  Allow audio driver to pass DB value to underlying drivers
  Pass raw DB values from hda-codec.c to audio driver
  If raw DB values are known, use them in paaudio

 audio/audio.c               | 15 +++++++++++++--
 audio/audio.h               |  6 ++++--
 audio/mixeng.h              |  6 ++++--
 audio/paaudio.c             |  9 +++++++--
 hw/audio/ac97.c             |  4 ++--
 hw/audio/hda-codec-common.h |  2 +-
 hw/audio/hda-codec.c        | 12 ++++++++++--
 hw/audio/lm4549.c           |  2 +-
 hw/audio/wm8750.c           | 18 ++++++++++++------
 hw/display/xlnx_dp.c        |  3 ++-
 hw/usb/dev-audio.c          |  6 ++++--
 11 files changed, 60 insertions(+), 23 deletions(-)

-- 
2.18.1

Sorry for a mess, forgot to add maintainer. Gerd, please, take a look
at these patches.

пт, 21 дек. 2018 г. в 22:40, Yaroslav Isakov <yaroslav.isakov@gmail.com>:
>
> This patch series introduces the ability for virtual audio drivers to pass
> information about guest-chosen DB values to backend audio drivers.
>
> For now, supported virtual driver is hda-codec, and backend is pulseaudio, as
> they both support DB values.
>
> Without these patches, emulated Windows has a very short range of hearable
> sound, as range in the guest is much smaller than in Pulseaudio.
>
> Yaroslav Isakov (3):
>   Allow audio driver to pass DB value to underlying drivers
>   Pass raw DB values from hda-codec.c to audio driver
>   If raw DB values are known, use them in paaudio
>
>  audio/audio.c               | 15 +++++++++++++--
>  audio/audio.h               |  6 ++++--
>  audio/mixeng.h              |  6 ++++--
>  audio/paaudio.c             |  9 +++++++--
>  hw/audio/ac97.c             |  4 ++--
>  hw/audio/hda-codec-common.h |  2 +-
>  hw/audio/hda-codec.c        | 12 ++++++++++--
>  hw/audio/lm4549.c           |  2 +-
>  hw/audio/wm8750.c           | 18 ++++++++++++------
>  hw/display/xlnx_dp.c        |  3 ++-
>  hw/usb/dev-audio.c          |  6 ++++--
>  11 files changed, 60 insertions(+), 23 deletions(-)
>
> --
> 2.18.1
>

Patchew URL: https://patchew.org/QEMU/cover.1545426882.git.yaroslav.isakov@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: cover.1545426882.git.yaroslav.isakov@gmail.com
Type: series
Subject: [Qemu-devel] [PATCH 0/3] Allow hw/audio drivers to pass raw DB values to audio/ drivers

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8eb6105 If raw DB values are known, use them in paaudio
5d986ae Pass raw DB values from hda-codec.c to audio driver
80db359 Allow audio driver to pass DB value to underlying drivers

=== OUTPUT BEGIN ===
Checking PATCH 1/3: Allow audio driver to pass DB value to underlying drivers...
ERROR: space required after that ';' (ctx:VxV)
#95: FILE: audio/mixeng.h:35:
+                       bool db_known; double r_db; double l_db;};
                                                               ^

total: 1 errors, 0 warnings, 193 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/3: Pass raw DB values from hda-codec.c to audio driver...
Checking PATCH 3/3: If raw DB values are known, use them in paaudio...
ERROR: line over 90 characters
#23: FILE: audio/paaudio.c:731:
+                v.values[0] = ((PA_VOLUME_NORM - PA_VOLUME_MUTED) * sw->vol.l) / UINT32_MAX;

ERROR: line over 90 characters
#24: FILE: audio/paaudio.c:732:
+                v.values[1] = ((PA_VOLUME_NORM - PA_VOLUME_MUTED) * sw->vol.r) / UINT32_MAX;

total: 2 errors, 0 warnings, 15 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1545426882.git.yaroslav.isakov@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

On Fri, Dec 21, 2018 at 10:14:42PM +0100, Yaroslav Isakov wrote:
> This patch series introduces the ability for virtual audio drivers to pass
> information about guest-chosen DB values to backend audio drivers.
> 
> For now, supported virtual driver is hda-codec, and backend is pulseaudio, as
> they both support DB values.
> 
> Without these patches, emulated Windows has a very short range of hearable
> sound, as range in the guest is much smaller than in Pulseaudio.

It's more useful to add support for converting db values to linear
values, so it'll work properly with all backends not only pulse.

cheers,
  Gerd