[Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message

Zhang Yi posted 7 patches 7 years, 2 months ago
There is a newer version of this series
[Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message
Posted by Zhang Yi 7 years, 2 months ago
object_get_canonical_path_component() returns a string which
must be freed using g_free().

Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
---
 numa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/numa.c b/numa.c
index 50ec016..3875e1e 100644
--- a/numa.c
+++ b/numa.c
@@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
             error_report("memory backend %s is used multiple times. Each "
                          "-numa option must use a different memdev value.",
                          path);
+            g_free(path);
             exit(1);
         }
 
-- 
2.7.4


Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message
Posted by Igor Mammedov 7 years, 2 months ago
On Tue, 20 Nov 2018 15:48:06 +0800
Zhang Yi <yi.z.zhang@linux.intel.com> wrote:

> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
> 
> Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  numa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/numa.c b/numa.c
> index 50ec016..3875e1e 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
>              error_report("memory backend %s is used multiple times. Each "
>                           "-numa option must use a different memdev value.",
>                           path);
> +            g_free(path);
>              exit(1);
>          }
>  


Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message
Posted by Pankaj Gupta 7 years, 2 months ago
> 
> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
> 
> Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
> ---
>  numa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/numa.c b/numa.c
> index 50ec016..3875e1e 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion
> *mr, Object *owner,
>              error_report("memory backend %s is used multiple times. Each "
>                           "-numa option must use a different memdev value.",
>                           path);
> +            g_free(path);
>              exit(1);
>          }
>  
> --

Reviewed-by: Pankaj gupta <pagupta@redhat.com>

> 2.7.4