Hello,

This is third version of this patch set, rebased on current
master.

As I've received no answers to [1] (and I'd prefer to keep the
patch as is for now if possible) this doesn't include any changes
to address the comments to [2].

If there's anything else I can do to get these patches merged
please tell me.

Regards
Simon

[1]: <20180424145053.GA21648@ruderich.org>
     https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg03894.html
[2]: <6f775e11a75a2faa1c66a86e6d23a97f695c2ca1.1523537181.git.simon@ruderich.org>
     https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg01757.html

Simon Ruderich (5):
  cpus: correct coding style in qmp_memsave/qmp_pmemsave
  cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open
  cpus: use size_t in qmp_memsave/qmp_pmemsave
  hmp: don't truncate size in hmp_memsave/hmp_pmemsave
  qmp: add pmemload command

 cpus.c          | 71 +++++++++++++++++++++++++++++++++++++++++++++------------
 hmp-commands.hx | 14 ++++++++++++
 hmp.c           | 16 +++++++++++--
 hmp.h           |  1 +
 qapi/misc.json  | 20 ++++++++++++++++
 5 files changed, 106 insertions(+), 16 deletions(-)

-- 
2.15.0

On Mon, May 21, 2018 at 05:36:39PM +0200, Simon Ruderich wrote:
> Hello,
>
> This is third version of this patch set, rebased on current
> master.
>
> As I've received no answers to [1] (and I'd prefer to keep the
> patch as is for now if possible) this doesn't include any changes
> to address the comments to [2].

Hello again,

I haven't received any answers in quite some time. Is there
anything I can do to get these patches merged? Are there any
issues left to resolve?

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Simon Ruderich <simon@ruderich.org> writes:

> On Mon, May 21, 2018 at 05:36:39PM +0200, Simon Ruderich wrote:
>> Hello,
>>
>> This is third version of this patch set, rebased on current
>> master.
>>
>> As I've received no answers to [1] (and I'd prefer to keep the
>> patch as is for now if possible) this doesn't include any changes
>> to address the comments to [2].
>
> Hello again,
>
> I haven't received any answers in quite some time. Is there
> anything I can do to get these patches merged? Are there any
> issues left to resolve?

You neglected to cc: maintainers.  I spotted this cry for help only by
chance.

To find maintainers to cc:, you can use get_maintainer.pl like this:

    $ scripts/get_maintainer.pl *patch
    scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't appear to be a patch.  Add -f to options?
    Paolo Bonzini <pbonzini@redhat.com> (maintainer:Overall)
    Peter Crosthwaite <crosthwaite.peter@gmail.com> (maintainer:Overall)
    Richard Henderson <rth@twiddle.net> (maintainer:Overall)
    "Dr. David Alan Gilbert" <dgilbert@redhat.com> (maintainer:Human Monitor (HMP))
    Eric Blake <eblake@redhat.com> (supporter:QAPI Schema)
    Markus Armbruster <armbru@redhat.com> (supporter:QAPI Schema)
    qemu-devel@nongnu.org (open list:Overall)

It's output is advice, not gospel.  Use your judgement.

I'm copying maintainers for you now.  This should get you some review.

On Fri, Aug 10, 2018 at 08:06:11AM +0200, Markus Armbruster wrote:
> You neglected to cc: maintainers.  I spotted this cry for help only by
> chance.
>
> To find maintainers to cc:, you can use get_maintainer.pl like this:
>
>     $ scripts/get_maintainer.pl *patch
>     scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't appear to be a patch.  Add -f to options?
>     Paolo Bonzini <pbonzini@redhat.com> (maintainer:Overall)
>     Peter Crosthwaite <crosthwaite.peter@gmail.com> (maintainer:Overall)
>     Richard Henderson <rth@twiddle.net> (maintainer:Overall)
>     "Dr. David Alan Gilbert" <dgilbert@redhat.com> (maintainer:Human Monitor (HMP))
>     Eric Blake <eblake@redhat.com> (supporter:QAPI Schema)
>     Markus Armbruster <armbru@redhat.com> (supporter:QAPI Schema)
>     qemu-devel@nongnu.org (open list:Overall)
>
> It's output is advice, not gospel.  Use your judgement.
>
> I'm copying maintainers for you now.  This should get you some review.

Hello,

Thank you for your help. I missed that part when looking through
the patch submission instructions.

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Simon Ruderich <simon@ruderich.org> writes:

> On Fri, Aug 10, 2018 at 08:06:11AM +0200, Markus Armbruster wrote:
>> You neglected to cc: maintainers.  I spotted this cry for help only by
>> chance.
>>
>> To find maintainers to cc:, you can use get_maintainer.pl like this:
>>
>>     $ scripts/get_maintainer.pl *patch
>>     scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't appear to be a patch.  Add -f to options?
>>     Paolo Bonzini <pbonzini@redhat.com> (maintainer:Overall)
>>     Peter Crosthwaite <crosthwaite.peter@gmail.com> (maintainer:Overall)
>>     Richard Henderson <rth@twiddle.net> (maintainer:Overall)
>>     "Dr. David Alan Gilbert" <dgilbert@redhat.com> (maintainer:Human Monitor (HMP))
>>     Eric Blake <eblake@redhat.com> (supporter:QAPI Schema)
>>     Markus Armbruster <armbru@redhat.com> (supporter:QAPI Schema)
>>     qemu-devel@nongnu.org (open list:Overall)
>>
>> It's output is advice, not gospel.  Use your judgement.
>>
>> I'm copying maintainers for you now.  This should get you some review.
>
> Hello,
>
> Thank you for your help. I missed that part when looking through
> the patch submission instructions.

Don't worry, we don't expect people to get it 100% right every time,
especially not the first time.