[Qemu-devel] [PATCH v2 01/32] qcow2: Fix documentation of get_cluster_table()

Alberto Garcia posted 32 patches 8 years, 1 month ago
There is a newer version of this series
[Qemu-devel] [PATCH v2 01/32] qcow2: Fix documentation of get_cluster_table()
Posted by Alberto Garcia 8 years, 1 month ago
This function has not been returning the offset of the L2 table since
commit 3948d1d4876065160583e79533bf604481063833

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 block/qcow2-cluster.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index a3fec27bf9..8163983d28 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -648,8 +648,7 @@ fail:
  * for a given disk offset, load (and allocate if needed)
  * the l2 table.
  *
- * the l2 table offset in the qcow2 file and the cluster index
- * in the l2 table are given to the caller.
+ * the cluster index in the l2 table is given to the caller.
  *
  * Returns 0 on success, -errno in failure case
  */
-- 
2.11.0


Re: [Qemu-devel] [PATCH v2 01/32] qcow2: Fix documentation of get_cluster_table()
Posted by Eric Blake 8 years ago
On 12/15/2017 06:53 AM, Alberto Garcia wrote:
> This function has not been returning the offset of the L2 table since
> commit 3948d1d4876065160583e79533bf604481063833
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/qcow2-cluster.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index a3fec27bf9..8163983d28 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -648,8 +648,7 @@ fail:
>   * for a given disk offset, load (and allocate if needed)
>   * the l2 table.
>   *
> - * the l2 table offset in the qcow2 file and the cluster index
> - * in the l2 table are given to the caller.
> + * the cluster index in the l2 table is given to the caller.
>   *
>   * Returns 0 on success, -errno in failure case
>   */
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org