Fix throttling crashes in BlockBackend with no BlockDriverState

[Qemu-devel] [PATCH 0/3] Fix throttling crashes in BlockBackend with no BlockDriverState

Alberto Garcia posted 3 patches 6 years, 5 months ago

Download series mbox

Failed in applying to current master (apply log)

block/block-backend.c      | 30 +++++++++++++---------
tests/qemu-iotests/093     | 62 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/093.out |  4 +--
3 files changed, 82 insertions(+), 14 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] Fix throttling crashes in BlockBackend with no BlockDriverState

Posted by Alberto Garcia 6 years, 5 months ago

Hi,

this series fixes the problems reported by Sochin Jiang in
BlockBackend when there's a valid throttling configuration but the BDS
has been removed.

The patches apply on top of Li Zhengui's "all I/O should be completed
before removing throttle timers" and I tested this on top of Stefan's
block branch (commit 900276cf24589596296d3d099fe609ad5c182ac9).

Regards,

Berto

Alberto Garcia (3):
  block: Check for inserted BlockDriverState in blk_io_limits_disable()
  block: Leave valid throttle timers when removing a BDS from a backend
  qemu-iotests: Test I/O limits with removable media

 block/block-backend.c      | 30 +++++++++++++---------
 tests/qemu-iotests/093     | 62 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/093.out |  4 +--
 3 files changed, 82 insertions(+), 14 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH 0/3] Fix throttling crashes in BlockBackend with no BlockDriverState

Posted by Stefan Hajnoczi 6 years, 5 months ago

On Fri, Nov 10, 2017 at 08:54:45PM +0200, Alberto Garcia wrote:
> Hi,
> 
> this series fixes the problems reported by Sochin Jiang in
> BlockBackend when there's a valid throttling configuration but the BDS
> has been removed.
> 
> The patches apply on top of Li Zhengui's "all I/O should be completed
> before removing throttle timers" and I tested this on top of Stefan's
> block branch (commit 900276cf24589596296d3d099fe609ad5c182ac9).
> 
> Regards,
> 
> Berto
> 
> Alberto Garcia (3):
>   block: Check for inserted BlockDriverState in blk_io_limits_disable()
>   block: Leave valid throttle timers when removing a BDS from a backend
>   qemu-iotests: Test I/O limits with removable media
> 
>  block/block-backend.c      | 30 +++++++++++++---------
>  tests/qemu-iotests/093     | 62 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/093.out |  4 +--
>  3 files changed, 82 insertions(+), 14 deletions(-)
> 
> -- 
> 2.11.0
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan