[v2] Don't write headers if BDS is INACTIVE

[Qemu-devel] [PATCH v2 0/3] Don't write headers if BDS is INACTIVE

Posted by Jeff Cody 6 years, 5 months ago

Changes from v1->v2:

* Drop previous parallels patches, just check BDRV_O_INACTIVE now
  (Kevin)

git-backport-diff -r qemu/master.. -u github/master
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[----] [--] 'block/vhdx.c: Don't blindly update the header'
002/3:[down] 'block/parallals: Do not update header or truncate image when INMIGRATE'
003/3:[----] [--] 'qemu-iotests: update unsupported image formats in 194'


v1:

VHDX and Parallels both blindly write headers to the image file
if the images are opened R/W.  This causes an assert if the QEMU run
state is INMIGRATE.

Jeff Cody (3):
  block/vhdx.c: Don't blindly update the header
  block/parallals: Do not update header or truncate image when INMIGRATE
  qemu-iotests: update unsupported image formats in 194

 block/parallels.c      | 7 ++-----
 block/vhdx.c           | 7 -------
 tests/qemu-iotests/194 | 2 +-
 3 files changed, 3 insertions(+), 13 deletions(-)

-- 
2.13.6

Re: [Qemu-devel] [PATCH v2 0/3] Don't write headers if BDS is INACTIVE

Posted by Alexey Kardashevskiy 6 years, 5 months ago

On 31/10/17 00:10, Jeff Cody wrote:
> Changes from v1->v2:
> 
> * Drop previous parallels patches, just check BDRV_O_INACTIVE now
>   (Kevin)
> 
> git-backport-diff -r qemu/master.. -u github/master
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
> 
> 001/3:[----] [--] 'block/vhdx.c: Don't blindly update the header'
> 002/3:[down] 'block/parallals: Do not update header or truncate image when INMIGRATE'
> 003/3:[----] [--] 'qemu-iotests: update unsupported image formats in 194'



Tested-by: Alexey Kardashevskiy <aik@ozlabs.ru>


> 
> v1:
> 
> VHDX and Parallels both blindly write headers to the image file
> if the images are opened R/W.  This causes an assert if the QEMU run
> state is INMIGRATE.
> 
> Jeff Cody (3):
>   block/vhdx.c: Don't blindly update the header
>   block/parallals: Do not update header or truncate image when INMIGRATE
>   qemu-iotests: update unsupported image formats in 194
> 
>  block/parallels.c      | 7 ++-----
>  block/vhdx.c           | 7 -------
>  tests/qemu-iotests/194 | 2 +-
>  3 files changed, 3 insertions(+), 13 deletions(-)
> 


-- 
Alexey

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] Don't write headers if BDS is INACTIVE

Posted by Stefan Hajnoczi 6 years, 5 months ago

On Mon, Oct 30, 2017 at 02:10:25PM +0100, Jeff Cody wrote:
> 
> Changes from v1->v2:
> 
> * Drop previous parallels patches, just check BDRV_O_INACTIVE now
>   (Kevin)
> 
> git-backport-diff -r qemu/master.. -u github/master
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
> 
> 001/3:[----] [--] 'block/vhdx.c: Don't blindly update the header'
> 002/3:[down] 'block/parallals: Do not update header or truncate image when INMIGRATE'

parallals?!  What happened here?  :)

> 003/3:[----] [--] 'qemu-iotests: update unsupported image formats in 194'
> 
> 
> v1:
> 
> VHDX and Parallels both blindly write headers to the image file
> if the images are opened R/W.  This causes an assert if the QEMU run
> state is INMIGRATE.
> 
> Jeff Cody (3):
>   block/vhdx.c: Don't blindly update the header
>   block/parallals: Do not update header or truncate image when INMIGRATE
>   qemu-iotests: update unsupported image formats in 194
> 
>  block/parallels.c      | 7 ++-----
>  block/vhdx.c           | 7 -------
>  tests/qemu-iotests/194 | 2 +-
>  3 files changed, 3 insertions(+), 13 deletions(-)
> 
> -- 
> 2.13.6
> 
>