Live block optional disable

[Qemu-devel] [PATCH v2 0/3] Live block optional disable

Posted by Jeff Cody 8 years, 2 months ago

This series adds a configurable option to disable live block operations.

The default is that live block operations are 'enabled'.

Jeffrey Cody (3):
  configure: Add option in configure to disable live block ops
  block-jobs: Optionally unregister live block operations
  hmp: Optionally disable live block operations in HMP monitor

 configure            | 11 +++++++++++
 hmp-commands-info.hx |  4 ++++
 hmp-commands.hx      | 12 ++++++++++++
 hmp.c                | 12 ++++++++++++
 monitor.c            | 16 ++++++++++++++++
 5 files changed, 55 insertions(+)

-- 
2.9.5

Re: [Qemu-devel] [PATCH v2 0/3] Live block optional disable

Posted by Eric Blake 8 years, 2 months ago

On 08/30/2017 12:01 PM, Jeff Cody wrote:
> This series adds a configurable option to disable live block operations.
> 
> The default is that live block operations are 'enabled'.
> 
> Jeffrey Cody (3):
>   configure: Add option in configure to disable live block ops
>   block-jobs: Optionally unregister live block operations
>   hmp: Optionally disable live block operations in HMP monitor

That doesn't match the spelling you've used on other contributions (see:
 git shortlog --author=Cody | grep -v "^ "
for a demonstration); is it intentional, and do you want a .mailmap
entry to merge your contributions under a preferred name?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v2 0/3] Live block optional disable

Posted by Eric Blake 8 years, 2 months ago

On 08/30/2017 12:01 PM, Jeff Cody wrote:
> This series adds a configurable option to disable live block operations.
> 
> The default is that live block operations are 'enabled'.
> 
> Jeffrey Cody (3):
>   configure: Add option in configure to disable live block ops
>   block-jobs: Optionally unregister live block operations
>   hmp: Optionally disable live block operations in HMP monitor

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

However, per the discussion on 2/3, you probably want a v2 of this
series after we land conditional QAPI support first.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] Live block optional disable

Posted by Kevin Wolf 8 years, 1 month ago

Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben:
> This series adds a configurable option to disable live block operations.
> 
> The default is that live block operations are 'enabled'.

Let me play dumb: Who would ever want to disable these? Is there a
legitimate reason to do this except artificially making qemu less
capable than it really is?

Kevin