[Qemu-devel] [PATCH 1/4] throttle: Fix wrong variable name in the header documentation

Alberto Garcia posted 4 patches 8 years, 5 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 1/4] throttle: Fix wrong variable name in the header documentation
Posted by Alberto Garcia 8 years, 5 months ago
The level of the burst bucket is stored in bkt.burst_level, not
bkt.burst_lenght.

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 include/qemu/throttle.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
index d056008c18..66a8ac10a4 100644
--- a/include/qemu/throttle.h
+++ b/include/qemu/throttle.h
@@ -63,7 +63,7 @@ typedef enum {
  * - The bkt.avg rate does not apply until the bucket is full,
  *   allowing the user to do bursts until then. The I/O limit during
  *   bursts is bkt.max. To enforce this limit we keep an additional
- *   bucket in bkt.burst_length that leaks at a rate of bkt.max units
+ *   bucket in bkt.burst_level that leaks at a rate of bkt.max units
  *   per second.
  *
  * - Because of all of the above, the user can perform I/O at a
-- 
2.11.0


Re: [Qemu-devel] [PATCH 1/4] throttle: Fix wrong variable name in the header documentation
Posted by Manos Pitsidianakis 8 years, 5 months ago
On Thu, Aug 17, 2017 at 05:28:12PM +0300, Alberto Garcia wrote:
>The level of the burst bucket is stored in bkt.burst_level, not
>bkt.burst_lenght.

s/lenght/length, otherwise:

Reviewed-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
>
>Signed-off-by: Alberto Garcia <berto@igalia.com>
>---
> include/qemu/throttle.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
>index d056008c18..66a8ac10a4 100644
>--- a/include/qemu/throttle.h
>+++ b/include/qemu/throttle.h
>@@ -63,7 +63,7 @@ typedef enum {
>  * - The bkt.avg rate does not apply until the bucket is full,
>  *   allowing the user to do bursts until then. The I/O limit during
>  *   bursts is bkt.max. To enforce this limit we keep an additional
>- *   bucket in bkt.burst_length that leaks at a rate of bkt.max units
>+ *   bucket in bkt.burst_level that leaks at a rate of bkt.max units
>  *   per second.
>  *
>  * - Because of all of the above, the user can perform I/O at a
>-- 
>2.11.0
>
>
Re: [Qemu-devel] [PATCH 1/4] throttle: Fix wrong variable name in the header documentation
Posted by Alberto Garcia 8 years, 5 months ago
On Sat 19 Aug 2017 04:29:47 PM CEST, Manos Pitsidianakis wrote:
> On Thu, Aug 17, 2017 at 05:28:12PM +0300, Alberto Garcia wrote:
>>The level of the burst bucket is stored in bkt.burst_level, not
>>bkt.burst_lenght.
>
> s/lenght/length, otherwise:

Oh my, fixing a typo by introducing another typo :-)

> Reviewed-by: Manos Pitsidianakis <el13635@mail.ntua.gr>

Berto