[v2] Implement a warning_report function

[Qemu-devel] [PATCH v2 8/8] error: Add a 'error: ' prefix to error_report()

Posted by Alistair Francis 8 years, 4 months ago

As we don't regard error messages as a stable API the let's add a
'error: ' prefix to the original error_report() messages.

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---

 util/qemu-error.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/qemu-error.c b/util/qemu-error.c
index b555247e24..cf1eb8e8b9 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -202,6 +202,7 @@ static void vreport(report_type type, const char *fmt, va_list ap)
 
     switch (type) {
     case REPORT_TYPE_ERROR:
+        error_printf("error: ");
         break;
     case REPORT_TYPE_WARNING:
         error_printf("warning: ");
-- 
2.11.0

Re: [Qemu-devel] [PATCH v2 8/8] error: Add a 'error: ' prefix to error_report()

Posted by Philippe Mathieu-Daudé 8 years, 4 months ago

On 07/07/2017 08:21 PM, Alistair Francis wrote:
> As we don't regard error messages as a stable API the let's add a
> 'error: ' prefix to the original error_report() messages.
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
> 
>   util/qemu-error.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index b555247e24..cf1eb8e8b9 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -202,6 +202,7 @@ static void vreport(report_type type, const char *fmt, va_list ap)
>   
>       switch (type) {
>       case REPORT_TYPE_ERROR:
> +        error_printf("error: ");
>           break;
>       case REPORT_TYPE_WARNING:
>           error_printf("warning: ");
>