[Qemu-devel] [RFC v2 0/3] Implement a warning_report function

Alistair Francis posted 3 patches 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1498761179.git.alistair.francis@xilinx.com
There is a newer version of this series
chardev/char-socket.c       |  2 +-
hw/virtio/virtio.c          |  2 +-
include/qemu/error-report.h | 10 +++++++++-
scripts/checkpatch.pl       |  3 ++-
util/qemu-error.c           | 37 ++++++++++++++++++++++++++++++++-----
5 files changed, 45 insertions(+), 9 deletions(-)
[Qemu-devel] [RFC v2 0/3] Implement a warning_report function
Posted by Alistair Francis 6 years, 9 months ago
QEMU currently has a standard method to report errors with
error_repot(). This ensure a sane and standard format when printing
errors. This series is attempting to extend this functionality for
warnings and information as well.

At the moment only one error is being converted, I wanted to get the
implementation nailed down a little bit before I started converting
others.

This patch renames error_print_loc() function to be more clear, but I
didn't bother renaming the others. It seems silly to change
error_printf() to error_warning_printf() and printf is already taken so
I just left it as is.

I also didn't change the current error output as that would probably
break backwards compatibilty for anyone who is parsing logs.

RFCv2:
 - Use enums for ERROR, WARN and INFO with a generic report() function
   instead of adding new functions

Alistair Francis (3):
  util/qemu-error: Rename error_print_loc() to be more generic
  qemu-error: Implement a more generic error reporting
  char-socket: Report TCP socket waiting as information

 chardev/char-socket.c       |  2 +-
 hw/virtio/virtio.c          |  2 +-
 include/qemu/error-report.h | 10 +++++++++-
 scripts/checkpatch.pl       |  3 ++-
 util/qemu-error.c           | 37 ++++++++++++++++++++++++++++++++-----
 5 files changed, 45 insertions(+), 9 deletions(-)

-- 
2.11.0