[Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup

Mao Zhongyi posted 6 patches 8 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1496387804.git.maozy.fnst@cn.fujitsu.com
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
hw/i386/amd_iommu.c                | 24 ++++++++----
hw/net/e1000e.c                    |  9 ++++-
hw/net/eepro100.c                  | 77 +++++++++++++++++++++-----------------
hw/pci-bridge/i82801b11.c          | 12 +++---
hw/pci-bridge/pcie_root_port.c     | 15 +++-----
hw/pci-bridge/xio3130_downstream.c | 20 +++++-----
hw/pci-bridge/xio3130_upstream.c   | 20 +++++-----
hw/pci/pci.c                       | 18 ++++-----
hw/pci/pci_bridge.c                |  8 +++-
hw/pci/pcie.c                      | 15 ++++++--
hw/pci/shpc.c                      |  5 ++-
hw/pci/slotid_cap.c                |  7 +++-
hw/vfio/pci.c                      |  5 ++-
hw/virtio/virtio-pci.c             | 19 +++++++---
include/hw/pci/pci.h               |  3 +-
include/hw/pci/pci_bridge.h        |  3 +-
include/hw/pci/pcie.h              |  3 +-
17 files changed, 154 insertions(+), 109 deletions(-)
[Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup
Posted by Mao Zhongyi 8 years, 5 months ago
v2:
* patch1: subject and commit message was rewrited by markus.
* patch2: comment was added to pci_add_capability2().
* patch3: a new patch that fix the wrong return value judgment condition.
* patch4: a new patch that fix code style problems.
* patch5: add an errp argument for pci_add_capability to pass
          error for its callers.
* patch6: convert part of pci-bridge device to realize.

v1:
* patch1: fix unreasonable return value check

Mao Zhongyi (6):
  pci: Clean up error checking in pci_add_capability()
  pci: Add comment for pci_add_capability2()
  pci: Fix the wrong return value judgment condition
  net/eepro100: Fixed code style
  pci: Make errp the last parameter of pci_add_capability()
  pci: Convert to realize

 hw/i386/amd_iommu.c                | 24 ++++++++----
 hw/net/e1000e.c                    |  9 ++++-
 hw/net/eepro100.c                  | 77 +++++++++++++++++++++-----------------
 hw/pci-bridge/i82801b11.c          | 12 +++---
 hw/pci-bridge/pcie_root_port.c     | 15 +++-----
 hw/pci-bridge/xio3130_downstream.c | 20 +++++-----
 hw/pci-bridge/xio3130_upstream.c   | 20 +++++-----
 hw/pci/pci.c                       | 18 ++++-----
 hw/pci/pci_bridge.c                |  8 +++-
 hw/pci/pcie.c                      | 15 ++++++--
 hw/pci/shpc.c                      |  5 ++-
 hw/pci/slotid_cap.c                |  7 +++-
 hw/vfio/pci.c                      |  5 ++-
 hw/virtio/virtio-pci.c             | 19 +++++++---
 include/hw/pci/pci.h               |  3 +-
 include/hw/pci/pci_bridge.h        |  3 +-
 include/hw/pci/pcie.h              |  3 +-
 17 files changed, 154 insertions(+), 109 deletions(-)

-- 
2.9.3




Re: [Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup
Posted by Michael S. Tsirkin 8 years, 5 months ago
Notes:
- Please write a cover letter explaining what this patchset is about
- Please add notes about how did you test it
- Pls copy everyone on the cover letter too.
- Please run a spell checker on comments and commit log

Thanks!

On Fri, Jun 02, 2017 at 03:54:36PM +0800, Mao Zhongyi wrote:
> v2:
> * patch1: subject and commit message was rewrited by markus.
> * patch2: comment was added to pci_add_capability2().
> * patch3: a new patch that fix the wrong return value judgment condition.
> * patch4: a new patch that fix code style problems.
> * patch5: add an errp argument for pci_add_capability to pass
>           error for its callers.
> * patch6: convert part of pci-bridge device to realize.
> 
> v1:
> * patch1: fix unreasonable return value check
> Mao Zhongyi (6):
>   pci: Clean up error checking in pci_add_capability()
>   pci: Add comment for pci_add_capability2()
>   pci: Fix the wrong return value judgment condition
>   net/eepro100: Fixed code style
>   pci: Make errp the last parameter of pci_add_capability()
>   pci: Convert to realize
> 
>  hw/i386/amd_iommu.c                | 24 ++++++++----
>  hw/net/e1000e.c                    |  9 ++++-
>  hw/net/eepro100.c                  | 77 +++++++++++++++++++++-----------------
>  hw/pci-bridge/i82801b11.c          | 12 +++---
>  hw/pci-bridge/pcie_root_port.c     | 15 +++-----
>  hw/pci-bridge/xio3130_downstream.c | 20 +++++-----
>  hw/pci-bridge/xio3130_upstream.c   | 20 +++++-----
>  hw/pci/pci.c                       | 18 ++++-----
>  hw/pci/pci_bridge.c                |  8 +++-
>  hw/pci/pcie.c                      | 15 ++++++--
>  hw/pci/shpc.c                      |  5 ++-
>  hw/pci/slotid_cap.c                |  7 +++-
>  hw/vfio/pci.c                      |  5 ++-
>  hw/virtio/virtio-pci.c             | 19 +++++++---
>  include/hw/pci/pci.h               |  3 +-
>  include/hw/pci/pci_bridge.h        |  3 +-
>  include/hw/pci/pcie.h              |  3 +-
>  17 files changed, 154 insertions(+), 109 deletions(-)
> 
> -- 
> 2.9.3
> 
> 
> 

Re: [Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup
Posted by Mao Zhongyi 8 years, 5 months ago
Hi, Michael

On 06/06/2017 11:23 PM, Michael S. Tsirkin wrote:
> Notes:
> - Please write a cover letter explaining what this patchset is about
> - Please add notes about how did you test it
> - Pls copy everyone on the cover letter too.
> - Please run a spell checker on comments and commit log
>
> Thanks!

OK, I see.
Thanks for your kind reminder.

Mao

>
> On Fri, Jun 02, 2017 at 03:54:36PM +0800, Mao Zhongyi wrote:
>> v2:
>> * patch1: subject and commit message was rewrited by markus.
>> * patch2: comment was added to pci_add_capability2().
>> * patch3: a new patch that fix the wrong return value judgment condition.
>> * patch4: a new patch that fix code style problems.
>> * patch5: add an errp argument for pci_add_capability to pass
>>           error for its callers.
>> * patch6: convert part of pci-bridge device to realize.
>>
>> v1:
>> * patch1: fix unreasonable return value check
>> Mao Zhongyi (6):
>>   pci: Clean up error checking in pci_add_capability()
>>   pci: Add comment for pci_add_capability2()
>>   pci: Fix the wrong return value judgment condition
>>   net/eepro100: Fixed code style
>>   pci: Make errp the last parameter of pci_add_capability()
>>   pci: Convert to realize
>>
>>  hw/i386/amd_iommu.c                | 24 ++++++++----
>>  hw/net/e1000e.c                    |  9 ++++-
>>  hw/net/eepro100.c                  | 77 +++++++++++++++++++++-----------------
>>  hw/pci-bridge/i82801b11.c          | 12 +++---
>>  hw/pci-bridge/pcie_root_port.c     | 15 +++-----
>>  hw/pci-bridge/xio3130_downstream.c | 20 +++++-----
>>  hw/pci-bridge/xio3130_upstream.c   | 20 +++++-----
>>  hw/pci/pci.c                       | 18 ++++-----
>>  hw/pci/pci_bridge.c                |  8 +++-
>>  hw/pci/pcie.c                      | 15 ++++++--
>>  hw/pci/shpc.c                      |  5 ++-
>>  hw/pci/slotid_cap.c                |  7 +++-
>>  hw/vfio/pci.c                      |  5 ++-
>>  hw/virtio/virtio-pci.c             | 19 +++++++---
>>  include/hw/pci/pci.h               |  3 +-
>>  include/hw/pci/pci_bridge.h        |  3 +-
>>  include/hw/pci/pcie.h              |  3 +-
>>  17 files changed, 154 insertions(+), 109 deletions(-)
>>
>> --
>> 2.9.3
>>
>>
>>
>
>
>