[Qemu-devel] [PATCH v7 00/13] Improvements for SM501 display controller emulation

BALATON Zoltan posted 13 patches 6 years, 12 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1492787889.git.balaton@eik.bme.hu
Test checkpatch passed
Test docker passed
Test s390x passed
default-configs/ppc-softmmu.mak    |    1 +
default-configs/ppc64-softmmu.mak  |    1 +
default-configs/ppcemb-softmmu.mak |    1 +
hw/display/sm501.c                 | 1784 ++++++++++++++++++++++--------------
hw/display/sm501_template.h        |   90 +-
hw/sh4/r2d.c                       |   11 +-
include/hw/devices.h               |    5 -
include/hw/pci/pci_ids.h           |    3 +
8 files changed, 1150 insertions(+), 746 deletions(-)
[Qemu-devel] [PATCH v7 00/13] Improvements for SM501 display controller emulation
Posted by BALATON Zoltan 6 years, 12 months ago
v7: Define default values for some variables to avoid an (invalid)
    warning from gcc 6 or 7 as suggested by Aurelien Jarno.

BALATON Zoltan (13):
  sm501: Fixed code style and a few typos in comments
  sm501: Use defined constants instead of literal values where available
  sm501: Add missing arbitration control register
  sm501: QOMify
  sm501: Get rid of base address in draw_hwc_line
  sm501: Add emulation of chip connected via PCI
  sm501: Fix device endianness
  sm501: Fix hardware cursor
  sm501: Misc clean ups
  sm501: Add support for panel layer
  sm501: Add some more missing registers
  sm501: Add vmstate descriptor
  ppc: Add SM501 device in ppc softmmu targets default configs

 default-configs/ppc-softmmu.mak    |    1 +
 default-configs/ppc64-softmmu.mak  |    1 +
 default-configs/ppcemb-softmmu.mak |    1 +
 hw/display/sm501.c                 | 1784 ++++++++++++++++++++++--------------
 hw/display/sm501_template.h        |   90 +-
 hw/sh4/r2d.c                       |   11 +-
 include/hw/devices.h               |    5 -
 include/hw/pci/pci_ids.h           |    3 +
 8 files changed, 1150 insertions(+), 746 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH v7 00/13] Improvements for SM501 display controller emulation
Posted by Aurelien Jarno 6 years, 12 months ago
On 2017-04-21 17:18, BALATON Zoltan wrote:
> v7: Define default values for some variables to avoid an (invalid)
>     warning from gcc 6 or 7 as suggested by Aurelien Jarno.

Thanks a lot for this new version, I confirm it now builds fine with GCC
6 or 7.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [PATCH v7 00/13] Improvements for SM501 display controller emulation
Posted by Peter Maydell 6 years, 12 months ago
On 21 April 2017 at 16:18, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> v7: Define default values for some variables to avoid an (invalid)
>     warning from gcc 6 or 7 as suggested by Aurelien Jarno.
>
> BALATON Zoltan (13):
>   sm501: Fixed code style and a few typos in comments
>   sm501: Use defined constants instead of literal values where available
>   sm501: Add missing arbitration control register
>   sm501: QOMify
>   sm501: Get rid of base address in draw_hwc_line
>   sm501: Add emulation of chip connected via PCI
>   sm501: Fix device endianness
>   sm501: Fix hardware cursor
>   sm501: Misc clean ups
>   sm501: Add support for panel layer
>   sm501: Add some more missing registers
>   sm501: Add vmstate descriptor
>   ppc: Add SM501 device in ppc softmmu targets default configs

Thanks for working through the code review process on this one.
Since SH4 is only 'odd fixes' and Aurelien has tested the code,
I've applied it directly to git master.

thanks
-- PMM