On Tue, Feb 28, 2017 at 10:51:02AM -0500, Jeff Cody wrote:
>
> This series adds blockdev-add for rbd.
>
>
> Changes from v3:
>
> Patch 5: Encapsulate ipv6 addresses with '[]' (Thanks Daniel, Eric, Markus)
> Free auth_supported (Thanks Markus)
> check error for qdict_array_entries (Thanks Markus)
> Make sure to return NULL on failure (Thanks Markus)
> Misc formatting (Thanks Markus)
>
>
> Changes from v2:
>
> Patch 2: Updated commit message, and documented the runtime opts
> (Thanks Eric)
>
> Patch 3: Fixed commit type, added "FIXME" in ugly string concat spot
> (Thanks Eric)
>
> Patch 4: Fixed all the nits - deleted lines, spaces. Kept list
> alphabetical. (Thanks Eric)
>
> Patch 5: Significant changes. Both 'mon_host' became 'server', and an array.
> 'auth_supported' became 'auth-supported', and an array.
> (Thanks Daniel, Eric)
>
> Patch 5 also contains a new function, qemu_rbd_array_opts(), to
> parse the array options.
>
>
> Changes from v1:
>
> Overall:
>
> * QAPI interface does not allow arbitrary key/value pairs
> in v2 (Thanks Daniel)
>
> * QAPI interface adds 'mon_host' and 'auth_supported' options (Thanks Daniel)
>
> * Use 'user' instead of 'rbd-id' (Thanks Daniel)
> v
> By patch:
>
> Patch 1:
> * Fixed some indentation in patch 1 (Thanks Markus)
>
> Patch 2:
> * 'rbd-id' becomes 'user', and the commit message is fixed. (Thanks Daniel)
>
> Patch 3:
> * Ripple-through from changes in patch 2
> * Removed the string unescape from qemu_rbd_set_keypairs(), because the
> strings have already been unescaped by the time they hit this function.
>
> Patch 4:
> * 'rbd-id' becomes 'user'
> * drop the 'keyvalue-pairs' from the QAPI (both, thanks Daniel)
>
> Patch 5:
> * new patch
> * Adds the 'server' (mon_host) and 'auth_supported' options to the
> QAPI (Thanks Daniel)
>
>
> Jeff Cody (5):
> block/rbd: don't copy strings in qemu_rbd_next_tok()
> block/rbd: add all the currently supported runtime_opts
> block/rbd: parse all options via bdrv_parse_filename
> block/rbd: add blockdev-add support
> block/rbd: add support for 'mon_host', 'auth_supported' via QAPI
>
> block/rbd.c | 568 ++++++++++++++++++++++++++++++++++-----------------
> qapi/block-core.json | 62 +++++-
> 2 files changed, 442 insertions(+), 188 deletions(-)
>
> --
> 2.9.3
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff